Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy-pass-params annotation and Backend field #1278

Merged
merged 1 commit into from
Sep 2, 2017
Merged

Add proxy-pass-params annotation and Backend field #1278

merged 1 commit into from
Sep 2, 2017

Conversation

antoineco
Copy link
Contributor

Some backends like Apache httpd accept parameters after proxy-pass directives. This annotation and global setting provide a place to set these.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 31, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 31, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 43.609% when pulling c0fecd5 on antoineco:proxy-pass-params into abc53cc on kubernetes:master.

@aledbf aledbf self-assigned this Sep 2, 2017
@aledbf
Copy link
Member

aledbf commented Sep 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2017
@aledbf
Copy link
Member

aledbf commented Sep 2, 2017

@antoineco thanks!

@aledbf aledbf merged commit 54459d8 into kubernetes:master Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@antoineco @k8s-reviewable @coveralls @aledbf @k8s-ci-robot