Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow client_body_buffer_size annotation from location / #1217

Closed

Conversation

diazjf
Copy link

@diazjf diazjf commented Aug 22, 2017

Currently when the client_body_buffer_size is set it configures all locations in the rules as well as location /. This will disallow client_body_buffer_size from being configured in / when it is not present in the rule.

Currently when the client_body_buffer_size is set it configures
all locations in the rules as well as location /. This will
disallow client_body_buffer_size from being configured in /.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@diazjf
Copy link
Author

diazjf commented Aug 22, 2017

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: ok-ingress
  annotations:
    ingress.kubernetes.io/client-body-buffer-size: 5k
spec:
  tls:
  - hosts:
    - ok.com
  rules:
  - host: ok.com
    http:
      paths:
      - path: /tea
        backend:
          serviceName: tea-svc
          servicePort: 80

produces https://pastebin.com/wPrVt9ZY only configuring /tea.

@diazjf
Copy link
Author

diazjf commented Aug 22, 2017

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: ok-ingress
  annotations:
    ingress.kubernetes.io/client-body-buffer-size: 5k
spec:
  tls:
  - hosts:
    - ok.com
  rules:
  - host: ok.com
    http:
      paths:
      - path: /tea
        backend:
          serviceName: tea-svc
          servicePort: 80

sets client_body_buffer_size to 5k to just location /.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.442% when pulling c61eb33 on diazjf:remove-size-setting-from-default into ed3803c on kubernetes:master.

@diazjf
Copy link
Author

diazjf commented Aug 23, 2017

fix already applied in #1233

@diazjf diazjf closed this Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants