[WIP] Change syncSecret approach #1030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
@jcmoraisjr we need secrReferenced because we must not dump all the secrets to file, only the ones that are being referenced by the ingress. |
|
@jcmoraisjr I was waiting the client-go PR to be merged to finish this |
aledbf
added a commit
to aledbf/ingress-nginx
that referenced
this pull request
Jul 28, 2017
aledbf
added a commit
that referenced
this pull request
Jul 28, 2017
Alternative syncSecret approach #1030
stibi
added a commit
to stibi/ingress
that referenced
this pull request
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend_ssl/secrReferencedis being used to check if a secret is used byauth-tls-secretannotation andspec.TLS attribute. This list goes beyond these two attributes, eg:auth-secret,secure-verify-ca-secretand some configmap options should also be checked. This list should grow. This was implemented on #991 .IOW the current (without this PR) behavior is try to guess when a secret should be added, which is not working if the secret is used eg on
auth-secretannotation.The PR implementation is half of the way to create a facade to find secrets. I added the only missing
ic.syncSecret()I found on my tests. This might be evolved to a single func that do this job (try/sync/try again). This PR works on my local env.Another approach is add every single secret without trying to guess if it is used or not.
What about these strategies?