ingress-nginx restart failed when annotation have invalid value

[annProg]

---

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

NGINX Ingress controller version: 0.13

Kubernetes version (use kubectl version): 1.9.5

Environment:

• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release): CentOS Linux release 7.4.1708
• Kernel (e.g. uname -a): 3.10.0-327.13.1.el7.x86_64
• Install tools: binary
• Others:

What happened:
add an invalid annotation:

"nginx.ingress.kubernetes.io/server-snippet": "hello"

ingress-nginx will produce error log:

Error: exit status 1
2018/10/10 08:06:07 [emerg] 428#428: unknown directive "hello" in /tmp/nginx-cfg590211687:350
nginx: [emerg] unknown directive "hello" in /tmp/nginx-cfg590211687:350
nginx: configuration file /tmp/nginx-cfg590211687 test failed

• When ingress-nginx pod is running ,invalid conf does not affect business.
• But when ingress-nginx pod restart , nginx can not start with the invalid conf.

What you expected to happen:
Ingress-nginx should hold the latest correct nginx configuration and use the correct conf to restart ingress-nginx pod.

How to reproduce it (as minimally and precisely as possible):
Add annotation with invalid value.

Anything else we need to know:

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.