Discuss rename of permanent-redirect and temporal-redirect annotation

[Stono]

Hey,
The work I did in #2834 allows you to control the status code used for permanent-redirects as there are a couple of valid options (301, 308 etc).

However the annotation we ended up using was called http-redirect-code which implies it could also be used to set short term redirects too (eg 302).

Whilst digging in that code, I also noticed there is another undocumented annotation temporal-redirect which appears to 302.

It's all getting a bit confusing, so I propose simply two annotations: http-redirect and http-redirect-code and getting rid of permanent-redirect and temporal-redirect which would then just allow people to use whichever of the 5 valid redirect codes they chose (301, 302, 303, 307, 308).

Naturally however this would be a breaking change so this issue is to talk about that...

[Stono]

I have also just noticed that there is a ConfigMap setting:

	// HTTPRedirectCode sets the HTTP status code to be used in redirects.
	// Supported codes are 301,302,307 and 308
	// Default: 308
	HTTPRedirectCode int `json:"http-redirect-code"`

This appears to only be used in http -> https redirects. So I believe this should be renamed to ssl-redirect-code, as that is what it ultimately impacts.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.