Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy_protocol - inbound or outbound #207

Closed
justinsb opened this issue Feb 2, 2017 · 1 comment
Closed

proxy_protocol - inbound or outbound #207

justinsb opened this issue Feb 2, 2017 · 1 comment
Labels

Comments

@justinsb
Copy link
Member

justinsb commented Feb 2, 2017

I think nginx can use the proxy protocol for inbound connections (useful if nginx has an upstream load balancer, like ELB) and it can also use the proxy protocol for connections to the backends.

My understanding is that if you put proxy_protocol on the listen line that configures the listener, wherease if you put it on its own line with proxy_protocol on that is for connections to downstreams (i.e. k8s pods).

So I think this should be on the listener:
https://github.com/kubernetes/ingress/blob/80e718b5241515de2935e7028486e29a5f49fda7/controllers/nginx/rootfs/etc/nginx/template/nginx.tmpl#L438

@aledbf
Copy link
Member

aledbf commented Feb 2, 2017

@justinsb what you describe applies to a server sections. The line you indicate is for the stream section https://nginx.org/en/docs/stream/ngx_stream_proxy_module.html#proxy_protocol

@aledbf aledbf added the nginx label Feb 3, 2017
justinsb added a commit to justinsb/ingress that referenced this issue Feb 4, 2017
Move proxy_protocol to listener.

Fix kubernetes#207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants