Make proxy_cookie_domain configurable as an annotation

[andrewl3wis]

FEATURE REQUEST

It looks like it is possible to set proxy_cookie_domain globally via the configmap configuration method, I'd like to request an override in the annotation syntax so that it could apply to a single ingress. Setting the values with both configuration-snippet and server-snippet annotation seem to fail and the proxy_cookie_domain off; that is in the default template takes precedence.

NGINX Ingress controller version: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.10.0

Kubernetes version (use kubectl version):
client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.2", GitCommit:"5fa2db2bd46ac79e5e00a4e6ed24191080aa463b", GitTreeState:"clean", BuildDate:"2018-01-18T21:12:46Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"9+", GitVersion:"v1.9.1-gke.0", GitCommit:"fec56df89314e4b1a05471d0bf80b259b84c289a", GitTreeState:"clean", BuildDate:"2018-01-05T03:10:24Z", GoVersion:"go1.9.2b4", Compiler:"gc", Platform:"linux/amd64"}

Environment:

• Cloud provider or hardware configuration: GKE
• OS (e.g. from /etc/os-release): Container-Optimized OS

[rashmi43]

I'd like to work on this.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[jstoja]

Hey @andrewl3wis it seems that this is already implemented here: https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/annotations/proxy/main.go#L133

Maybe @aledbf can confirm this ? :)

[aledbf]

@jstoja you are right. The missing part is the docs https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/