Avoid running nginx if the configuration file is empty

kubernetes · Apr 27, 2017 · f4147e9 · f4147e9
1 parent 7eee34f
commit f4147e9
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/controllers/nginx/pkg/cmd/controller/nginx.go b/controllers/nginx/pkg/cmd/controller/nginx.go
@@ -334,6 +334,9 @@ func (n NGINXController) DefaultIngressClass() string {
 // testTemplate checks if the NGINX configuration inside the byte array is valid
 // running the command "nginx -t" using a temporal file.
 func (n NGINXController) testTemplate(cfg []byte) error {
+	if len(cfg) == 0 {
+		return fmt.Errorf("invalid nginx configuration (empty)")
+	}
 	tmpfile, err := ioutil.TempFile("", "nginx-cfg")
 	if err != nil {
 		return err