Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kube-config for CRD informers #1051

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Fix kube-config for CRD informers #1051

merged 1 commit into from
Mar 11, 2020

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Mar 11, 2020

Fixes #1049

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2020
@skmatti
Copy link
Contributor Author

skmatti commented Mar 11, 2020

/assign @freehan

freehan
freehan reviewed Mar 11, 2020
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit

otherwise, LGTM

cmd/glbc/main.go
if err != nil {
klog.Fatalf("Failed to create kubernetes client for leader election: %v", err)
}

// Create kube-config for CRDs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
TODO: migrate to use protobuf once CRD supports.

@freehan
Copy link
Contributor

freehan commented Mar 11, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2020
@skmatti skmatti force-pushed the crd-informers-fix branch from b58111f to d92d74e Compare March 11, 2020 23:09
@freehan
Copy link
Contributor

freehan commented Mar 11, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 51d9a0e into kubernetes:master Mar 11, 2020
skmatti added a commit to skmatti/ingress-gce that referenced this pull request Mar 12, 2020
@skmatti
Cherrypick kubernetes#1051[Fix kube-config for CRD informers] into re…
4f65a71 
…lease-1.8
skmatti added a commit to skmatti/ingress-gce that referenced this pull request Mar 12, 2020
@skmatti
Cherrypick kubernetes#1051[Fix kube-config for CRD informers] into re…
68f09ad 
…lease-1.7
skmatti added a commit to skmatti/ingress-gce that referenced this pull request Mar 12, 2020
@skmatti
Cherrypick kubernetes#1051[Fix kube-config for CRD informers] into re…
13250cd 
…lease-1.7
skmatti added a commit to skmatti/ingress-gce that referenced this pull request Mar 12, 2020
@skmatti
Cherrypick kubernetes#1051[Fix kube-config for CRD informers] into re…
f6c879a 
…lease-1.8
k8s-ci-robot added a commit that referenced this pull request Mar 13, 2020
@k8s-ci-robot
Merge pull request #1053 from skmatti/informers-fix-1.7
5b809df 
Cherrypick #1051[Fix kube-config for CRD informers] into release-1.7
k8s-ci-robot added a commit that referenced this pull request Mar 13, 2020
@k8s-ci-robot
Merge pull request #1052 from skmatti/informers-fix-v1.8
3829313 
Cherrypick #1051[Fix kube-config for CRD informers] into release-1.8
k8s-ci-robot added a commit that referenced this pull request Mar 13, 2020
@k8s-ci-robot
Merge pull request #1054 from skmatti/informers-fix-1.9
f42f0b3 
Cherrypick #1051[Fix kube-config for CRD informers] into release-1.9
@skmatti skmatti deleted the crd-informers-fix branch March 13, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan freehan left review comments

@bowei bowei Awaiting requested review from bowei

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backendconfig and Frontendconfig CRD informers break with protobuf
3 participants
@skmatti @k8s-ci-robot @freehan