Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test plan to pod DNS config KEP #867

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Add test plan to pod DNS config KEP #867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions keps/sig-network/20190118-pod-dns-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ status: implementable
* [Proposal](#proposal)
* [Pod API examples](#pod-api-examples)
* [API changes](#api-changes)
* [Test Plan](#test-plan)
* [Graduation Criteria](#graduation-criteria)
* [Implementation History](#implementation-history)

Expand Down Expand Up @@ -231,6 +232,14 @@ The follow configurations will result in an invalid Pod spec:
search paths, 256 characters for `glibc`).
* Invalid option appears for the given platform.

### Test Plan

The following end-to-end test is implemented in addition to unit tests:
- Create a pod with dns config setup, including nameserver, search path and option.
- Check if the `resolv.conf` file within the pod is configured properly per the given setup.
- Send DNS request from the pod and make sure the customized nameserver and
search path are taking effect.

## Graduation Criteria

* Enable by default and soak for 1+ releases
Expand Down