-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webhook admission KEP updates #806
Webhook admission KEP updates #806
Conversation
ea8ecd9
to
455a96c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I can LGTM too but maybe it's good to have e.g. @deads2k sign off too?
455a96c
to
3359d57
Compare
3359d57
to
7b7fc0c
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, lavalamp, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
follow up to #736 (comment)
*
for scope field (Admission Webhook to GA #736 (comment))Marks as implementable overall since there is implementation work that can begin on many of the items (the "convert-to-requested version" and "plugin ordering / re-call" subparts are explicitly noted to require that designs are to be merged to this doc before they will be considered implementable)
/sig api-machinery
/assign @lavalamp @deads2k @mbohlool