Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook admission KEP updates #806

Merged
merged 5 commits into from
Feb 4, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 4, 2019

follow up to #736 (comment)

Marks as implementable overall since there is implementation work that can begin on many of the items (the "convert-to-requested version" and "plugin ordering / re-call" subparts are explicitly noted to require that designs are to be merged to this doc before they will be considered implementable)

/sig api-machinery
/assign @lavalamp @deads2k @mbohlool

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2019
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/pm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2019
@liggitt liggitt force-pushed the implementable-admission branch 2 times, most recently from ea8ecd9 to 455a96c Compare February 4, 2019 15:56
Copy link
Member

@lavalamp lavalamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I can LGTM too but maybe it's good to have e.g. @deads2k sign off too?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2019
@liggitt liggitt force-pushed the implementable-admission branch from 455a96c to 3359d57 Compare February 4, 2019 17:24
@liggitt liggitt force-pushed the implementable-admission branch from 3359d57 to 7b7fc0c Compare February 4, 2019 17:32
@deads2k
Copy link
Contributor

deads2k commented Feb 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, lavalamp, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d45b8ee into kubernetes:master Feb 4, 2019
@liggitt liggitt deleted the implementable-admission branch February 4, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants