Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the k8s.io/component-base KEP #653

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

luxas
Copy link
Member

@luxas luxas commented Dec 10, 2018

Follow-up of kubernetes/community#2977
xref: kubernetes/community#2354 kubernetes/community#2515

cc @kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/sig-api-machinery-pr-reviews
/assign @thockin @mtaufen @sttts @jbeda @DirectXMan12 @bgrant0607

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Dec 10, 2018
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Dec 10, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Dec 10, 2018
@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/pm approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 10, 2018
@luxas luxas changed the title Update the k8s.io/component repo Update the k8s.io/component KEP Dec 10, 2018
@mtaufen
Copy link
Contributor

mtaufen commented Dec 11, 2018

Looks good

Thoughts on calling the wg "Component Standard"?

All these sound ok to me for a repo name:

  • component-toolkit
  • component-base
  • component-foundation
  • componentlib

@luxas luxas force-pushed the update_component_kep branch from 0b69cb6 to f300591 Compare December 11, 2018 05:18
@luxas
Copy link
Member Author

luxas commented Dec 11, 2018

Thoughts on calling the wg "Component Standard"?

As agreed with @mtaufen & @sttts and other stakeholders at the contrib summit, we're going with this WG name. This doc is updated to reflect that

component-base

After some bikeshedding on the names back and forth, we agreed that this is the best name we have at the moment. Before this is going "GA/stable", we could technically always rename this if there's a strong case later. Updated this proposal to reflect the k8s.io/component-base change.

This is ready to merge.

@luxas luxas changed the title Update the k8s.io/component KEP Update the k8s.io/component-base KEP Dec 11, 2018
@mtaufen
Copy link
Contributor

mtaufen commented Dec 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, mtaufen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants