KEP-1860 - Propose beta graduation and add missing PRR #4509
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
kind/kep
rikatz
force-pushed
the
lbipmode-to-beta
branch
from
f8b6a96
to
430f4a7
Compare
|
/assign @RyanAoh Feel free to refuse it, or otherwise use any of the additions here on your original KEP proposal. Thanks! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@wojtek-t as Dan approved it, can we now take a look into the PRR (once you have time!). Thanks!! |
|
I'm sorry for delay - will get to it tomorrow morning. |
kikisdeliveryservice
changed the title
| Longer term, we may want to require automated upgrade/rollback tests, but we | ||
| are missing a bunch of machinery and tooling and can't do that now. | ||
| --> | ||
| No. |
There was a problem hiding this comment.
We should test that before enabling Beta by default.
Can you please describe the scenario here now (and ensure that you actually run it - manual run is fine) before enabling beta?
There was a problem hiding this comment.
Will do next here, will keep this thread open and close once I have results
There was a problem hiding this comment.
@wojtek-t did the test here. Just a node (that I have added to the KEP), because this feature is mostly related to cloud providers, the test I did was, on a 3 node KinD cluster, enabled the feature flag, installed MetalLB as the LB, ran some tests, and disabled the Feature flag to check how kube-proxy and apiserver would behave.
It is registered on the steps, let me know if you need something else.
k8s-ci-robot
removed
the
lgtm
rikatz
force-pushed
the
lbipmode-to-beta
branch
from
f9f537e
to
c5ccc0c
Compare
| * Confirmed that both iptables rules are present, even if the `ipMode` field was still | ||
| set as `Proxy`, confirming the feature is disabled. Both accesses are working | ||
|
|
||
| Additionally, an apiserver and kube-proxy upgrade test was executed as the following: |
There was a problem hiding this comment.
@wojtek-t added the additional test of v1.28 -> v1.29 -> v1.28 and worked fine. All tests were executed with KinD and metallb.
|
Thank you - this looks great now! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, rikatz, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
One-line PR description: Add missing PRR descriptions and propose beta graduation for KEP 1860
Issue link: Make Kubernetes aware of the LoadBalancer behaviour #1860
Other comments: Will try to achieve PRR review and exception for v1.30, sorry for missing this train!