Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-2400] update latest milestone for swap KEP #4484

Merged
merged 3 commits into from
Feb 6, 2024
Merged

[KEP-2400] update latest milestone for swap KEP #4484

merged 3 commits into from
Feb 6, 2024

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Feb 6, 2024 •
edited
Loading

  • One-line PR description: update swap for latest-milestone.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Feb 6, 2024

updating the swap KEP to reflect our two-stage beta process.
/assign @deads2k

You mentioned it looks good in this round so not sure if you want to look it over and let me know about the PRR review here.

@kannon92
Copy link
Contributor Author

kannon92 commented Feb 6, 2024

hmm. we can't actually have a beta2 for KEP it seems.

@kannon92 kannon92 closed this Feb 6, 2024
@kannon92 kannon92 reopened this Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Feb 6, 2024

decided to drop beta2 and mark it as latest-milestone for 1.30.

@kannon92 kannon92 changed the title [KEP-2400] PRR review for beta2 [KEP-2400] update latest milestone for swap KEP Feb 6, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Feb 6, 2024

/unassign @deads2k
/assign @mrunalp

@k8s-ci-robot k8s-ci-robot assigned mrunalp and unassigned deads2k Feb 6, 2024
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 56f23d1 into kubernetes:master Feb 6, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 6, 2024
@pacoxu pacoxu mentioned this pull request Aug 9, 2024
Open
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@mrunalp mrunalp

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
5 participants
@kannon92 @haircommander @k8s-ci-robot @mrunalp @deads2k