Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote KEP-2644 to beta in 1.31 #4397

Merged
merged 1 commit into from
May 14, 2024
Merged

promote KEP-2644 to beta in 1.31 #4397

merged 1 commit into from
May 14, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Jan 9, 2024

  • One-line PR description: changes KEP-2644 beta target to 1.30
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jan 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2024
@carlory
Copy link
Member Author

carlory commented Jan 9, 2024

/cc @deepakkinni

soltysh
soltysh reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#prr-shadow
Several comments/suggestions from prr-shadow:

  1. The state of this KEP is confusing, theoretically https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-storage/2644.yaml claims it's beta, but both https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L287-L293 and this doc mention it's alpha. So I'm assuming you're targeting beta in 1.30, so I'd suggest to update https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-storage/2644.yaml once again with information about new PRR approver for beta, which will happen here.
  2. Update the document to match the new template (https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md)
  3. Release Signoff Checklist needs to be updated to reflect reality.
  4. Update tests coverage in unit tests, links in integration and e2e (see new template).
  5. Several questions in PRR section missing (see new template)
  6. Update implementation history.

keps/sig-storage/2644-honor-pv-reclaim-policy/kep.yaml Outdated
@@ -18,12 +18,12 @@ replaces:

stage: alpha

latest-milestone: "v1.26"
latest-milestone: "v1.30"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stage above needs to update to reflect beta transition.

@deepakkinni
Copy link
Member

@carlory We can't move this to beta yet, we need additional tests to be written for that.

@carlory
Copy link
Member Author

carlory commented Feb 6, 2024

@deepakkinni thanks for your review. kubernetes/kubernetes#123151 will add e2e test.

@soltysh soltysh mentioned this pull request Apr 3, 2024
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
@carlory carlory changed the title changes KEP-2644 beta target to 1.30 promote KEP-2644 to beta in 1.31 May 13, 2024
@carlory
Copy link
Member Author

carlory commented May 13, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2024
@carlory
Copy link
Member Author

carlory commented May 13, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@carlory carlory mentioned this pull request May 13, 2024
Merged
@xing-yang
Copy link
Contributor

@carlory Why do you add the "hold" to this PR? Are you waiting for anything else?

@xing-yang
Copy link
Contributor

This KEP can be merged now since the e2e tests PR has already been merged.

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 13, 2024
@deepakkinni
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, deepakkinni, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@carlory
Copy link
Member Author

carlory commented May 14, 2024 •
edited
Loading

@carlory Why do you add the "hold" to this PR? Are you waiting for anything else?

@xing-yang It needs to be rewritten with the latest template.

- [Design Details](#design-details)
  - [Test Plan](#test-plan)
    - [Prerequisite testing updates](#prerequisite-testing-updates)
    - [Unit tests](#unit-tests)
    - [Integration tests](#integration-tests)

- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
  - [Rollout, Upgrade and Rollback Planning](#rollout-upgrade-and-rollback-planning)
  - [Dependencies](#dependencies)
  - [Troubleshooting](#troubleshooting)

the above chapters do not exist. Do we need to add these to this PR?

@carlory
Copy link
Member Author

carlory commented May 14, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@carlory
Copy link
Member Author

carlory commented May 14, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@carlory
Copy link
Member Author

carlory commented May 14, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4492ebd into kubernetes:master May 14, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 14, 2024
@xing-yang xing-yang mentioned this pull request Jun 5, 2024
Open
10 tasks
@carlory carlory mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

@deepakkinni deepakkinni Awaiting requested review from deepakkinni

Assignees

@xing-yang xing-yang

@deepakkinni deepakkinni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
6 participants
@carlory @deepakkinni @k8s-triage-robot @xing-yang @k8s-ci-robot @soltysh