Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update status of Kubelet Resource Metrics KEP to implemented #4388

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Update status of Kubelet Resource Metrics KEP to implemented #4388

merged 1 commit into from
Feb 5, 2024

Conversation

richabanker
Copy link
Contributor

  • One-line PR description: Updated status of KEP-727 to implemented

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 6, 2024
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2024
@richabanker richabanker mentioned this pull request Jan 6, 2024
Closed
10 tasks
@kikisdeliveryservice
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@richabanker
Copy link
Contributor Author

/assign @dchen1107

@dashpole
Copy link
Contributor

/lgtm
/approve
I can confirm that this is implemented.

SergeyKanzhelev
SergeyKanzhelev approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@dchen1107
Copy link
Member

/lgtm
/approve

@dashpole
Copy link
Contributor

@kikisdeliveryservice this appears to need your approval

@richabanker
Copy link
Contributor Author

@kikisdeliveryservice gentle reminder for you to take a look. Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107, mrunalp, Richabanker, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3b6832c into kubernetes:master Feb 5, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@mrunalp mrunalp mrunalp approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@dashpole dashpole

@kikisdeliveryservice kikisdeliveryservice

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
7 participants
@richabanker @kikisdeliveryservice @dashpole @dchen1107 @k8s-ci-robot @mrunalp @SergeyKanzhelev