KEP-3960: promote to beta in 1.30

[AxeZhan]

• One-line PR description:
  Promote KEP-3960 to beta in 1.30

• Issue link: Introducing Sleep Action for PreStop Hook #3960

• Other comments:

Works will be done for beta

1. Add additional e2e test cases.
2. Add one metric

[AxeZhan]

/cc @thockin

[AxeZhan]

And a draft code in k/k: kubernetes/kubernetes#122456

[AxeZhan]

kindly ping @thockin

[thockin]

@kannon92 has one open

/lgtm
/approve

[thockin]

I am good with it - @kannon92 ?

/lgtm
/hold
/approve

[thockin]

Oh, right - this being sig-node I can't approve anyway.

@SergeyKanzhelev @dchen1107 @mrunalp @derekwaynecarr

[wojtek-t]

@wojtek-t Can you take a look at PRR? Since you reviewed PRR for this KEP in alpha, and there are only minor changes in beta.

yes - will review later this week

[AxeZhan]

/cc @mrunalp @dchen1107 @SergeyKanzhelev @klueska

[wojtek-t]

Just one small comment - other than that LGTM

[wojtek-t]

Copying from the KEP template:

Additionally, for features that are introducing a new API field, unit tests that
are exercising the `switch` of feature gate itself (what happens if I disable a
feature gate after having objects written with the new field) are also critical.
You can take a look at one potential example of such test in:
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282

I'm actually more interested in sth like that - this question is not about testing the feature itself (testing code with FG enabled), but rather testing the transition between enabled and disabled (and vice versa).

[AxeZhan]

... Yea, I think we need a test like this for this feature. But I clearly misunderstood this and missed this in alpha🤦.
I'll bring this test in beta, I added some cases in Unit tests for beta.

[wojtek-t]

Thanks!

/lgtm
/approve PRR

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AxeZhan, mrunalp, thockin, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/prod-readiness/OWNERS [wojtek-t]
• keps/sig-node/OWNERS [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AxeZhan]

/hold cancel