Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move sidecar to milestone 1.28 #3968

Merged
merged 1 commit into from
Jun 12, 2023
Merged

move sidecar to milestone 1.28 #3968

merged 1 commit into from
Jun 12, 2023

Conversation

SergeyKanzhelev
Copy link
Member

  • One-line PR description:

/sig node
moving sidecar container KEP to 1.28

  • Other comments:

No changes to scope or design

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2023
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Apr 27, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 27, 2023
mrunalp
mrunalp approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023
@mrunalp
Copy link
Contributor

mrunalp commented Apr 27, 2023

@dchen1107 ptal

gjkim42 referenced this pull request May 3, 2023
@SergeyKanzhelev
Sidecar containers KEP (#3761)
0dc6db7 
* sidecar container KEP

* sidecar container KEP

* applied the feedback
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2023
@alculquicondor
Copy link
Member

/cc

wojtek-t
wojtek-t reviewed May 29, 2023
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few smaller comments, but overall this looks reasonable.

keps/sig-node/753-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/753-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/753-sidecar-containers/README.md Outdated Show resolved Hide resolved
wojtek-t
wojtek-t reviewed May 29, 2023
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few smaller comments, but overall this looks reasonable.

@wojtek-t wojtek-t self-assigned this May 29, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2023
@Atharva-Shinde Atharva-Shinde mentioned this pull request Jun 9, 2023
Open
11 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@wojtek-t
Copy link
Member

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 56e3e45 into kubernetes:master Jun 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 12, 2023
@dims dims mentioned this pull request Jun 12, 2023
Closed
@SergeyKanzhelev SergeyKanzhelev deleted the sidecarGoes128 branch June 13, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@pacoxu pacoxu pacoxu left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@gjkim42 gjkim42 gjkim42 left review comments

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@mrunalp mrunalp

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
7 participants
@SergeyKanzhelev @mrunalp @alculquicondor @k8s-ci-robot @wojtek-t @pacoxu @gjkim42