Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1880: updating KEP #3844

Merged
merged 8 commits into from
Feb 7, 2023
Merged

KEP-1880: updating KEP #3844

merged 8 commits into from
Feb 7, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Feb 6, 2023

During the implementation some assumptions were found to be different, per example, the kubernetes.default Service logic and the bootstrap process can not be changed without breaking compatibility

Ref #1880 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2023
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Feb 6, 2023
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2023
@aojea aojea mentioned this pull request Feb 6, 2023
Open
12 tasks
@aojea
Copy link
Member Author

aojea commented Feb 6, 2023

/assign @thockin

thockin
thockin reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems MOSTLY like just renaming the type - am I missing some deeper importance (other than what I flagged) ?

keps/sig-network/1880-multiple-service-cidrs/README.md Outdated Show resolved Hide resolved
@aojea
Copy link
Member Author

aojea commented Feb 6, 2023

This seems MOSTLY like just renaming the type - am I missing some deeper importance (other than what I flagged) ?

  1. No need for IPAddress controller since we are not going to use finalizers
  2. No need for a controller on the controller manager, each apiserver will reconcile ServiceCIDRs and IPAddresses
  3. The bootstrap process follows now the kubernetes.default Service logic, first APIServer in creating something wins, the others follow (compared with previously behavior, at least the other APIservers syncs)

@thockin
Copy link
Member

thockin commented Feb 6, 2023

I know this is super tedious but...can you break this into commits? 1 just has renames, no other text chnges, then others that highlight specific semantic changes?

@aojea
Copy link
Member Author

aojea commented Feb 6, 2023

I know this is super tedious but...can you break this into commits? 1 just has renames, no other text chnges, then others that highlight specific semantic changes?

is ok, let me do this right

@aojea
update kep metadata
1de6e91
@aojea
update questionary
d7560d9
@aojea
Replace API name ServiceCIDRConfig by ServiceCIDR
2232222
@aojea
be compatible with current service IP reservation
b8c970d
@aojea
update test plan
8af5e86
@aojea
define number of controllers required
0e02167 
There is no need to handle the IPAddresses with finalizers since
the apiserver only deallocates the IP after the Services has been
deleted.

The repair loop on the apiserver will guarantee the relaton between
ServiceCIDR, Services and ClusterIP, there is no need to add a new
controller on the controller manager.
@aojea
bootstrap process
756f008
thockin
thockin reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one comment - thanks for breaking it up - SO much easier.

keps/sig-network/1880-multiple-service-cidrs/README.md Outdated Show resolved Hide resolved
@thockin
Copy link
Member

thockin commented Feb 7, 2023

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4483c24 into kubernetes:master Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
3 participants
@aojea @thockin @k8s-ci-robot