-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2799: update for LegacyServiceAccountTokenTracking beta #3696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, lgtm otherwise
- [ ] Approved by PRR and scalability | ||
- [ ] Any known bugs fixed | ||
- [ ] Tests passing | ||
- [x] In use by multiple distributions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can claim this one yet, and I'd actually have expected this to be a beta → GA graduation criteria (it's listed there... I'd recommend dropping this line from the alpha → beta list)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's right. done.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, zshihang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alpha: "v1.24" | ||
beta: "v1.25" | ||
beta: "v1.24" | ||
stable: "v1.26" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be too late to raise but I am confused by the milestone labels here. Is this targeting beta in 1.27? If so, it seems not matching here. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rollout of this KEP has three pieces, the first of which graduated to stable in 1.26 (LegacyServiceAccountTokenNoAutoGeneration)
LegacyServiceAccountTokenTracking graduates to beta in 1.27
the KEP template doesn't have a way to track progressive rollout of successive pieces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. In this case I guess the PRR section could be considered as approved earlier. Thanks
One-line PR description:
updating beta criteria and outdated text.
Issue link: Reduction of Secret-based Service Account Tokens #2799