Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3488: Resolve outstanding issue: handling of enforcement #3576

Merged
merged 3 commits into from
Oct 3, 2022
Merged

KEP-3488: Resolve outstanding issue: handling of enforcement #3576

merged 3 commits into from
Oct 3, 2022

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Oct 3, 2022 •
edited
Loading

  • One-line PR description: Clear last remaining phase 1 UNRESOLVED: handling of enforcement

Reviewers: The "Decisions and Enforcement" section summaries the core change proposed.

  • Issue link: CEL for Admission Control #3488

  • Other comments: We only have 5 weeks to implement this so we're keeping phase 1 to a minimum. We will do more design work for phase 2, but believe we have enough information to implement phase 1 without painting ourselves into a corner.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2022
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2022
@jpbetz jpbetz force-pushed the enforcement branch 3 times, most recently from 074be4c to c594d24 Compare October 3, 2022 20:20
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2022
@jpbetz jpbetz changed the title KEP-3488: Resolve outstanding issues, mark as implementable KEP-3488: Resolve outstanding issue: handling of enforcement Oct 3, 2022
@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 3, 2022

Thanks @lavalamp! Feedback applied.

@lavalamp
Copy link
Member

lavalamp commented Oct 3, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e7470e0 into kubernetes:master Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@apelisse apelisse Awaiting requested review from apelisse

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@lavalamp lavalamp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
3 participants
@jpbetz @lavalamp @k8s-ci-robot