-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated swap KEP: targeting alpha2 in 1.26 #3571
Conversation
ca06b3c
to
0e1fb36
Compare
|
||
- Add e2e tests that exercise all available swap configurations via the CRI. | ||
- Verify MemoryPressure behavior with swap enabled and document any changes | ||
for configuring eviction. | ||
- Verify new system-reserved settings for swap memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify a little bit on "Verify" here? Manual testing and figure out the work items for beta? Document the changes to guide the users for the alpha feature?
/lgtm When you mentioned to have the feature staying at alpha, but move it to alpha2, I didn't understand the reasons. Now I see. There are some unknowns in previous alpha stage (management overhead reservation, security, etc.), while more new changes around the feature (cgroup v2, etc.). Thanks for making sure the feature can be used easier as alpha. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc/ @mrunalp for vis. |
Updated SWAP KEP to indicate that in 1.26 we will be working on the feature but are not ready to promote it to beta. The reason for this is that there are still many uncertainty with what guarantees we can provide and whether the feature can destabilize the system.
One possible outcome of alpha2 work is that we may decide to limit the feature to cgroupv2.
Before this is investigated, it's better to keep feature in alpha stage.
/sig node
/assign @dchen1107 @derekwaynecarr