Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated swap KEP: targeting alpha2 in 1.26 #3571

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

SergeyKanzhelev
Copy link
Member

Updated SWAP KEP to indicate that in 1.26 we will be working on the feature but are not ready to promote it to beta. The reason for this is that there are still many uncertainty with what guarantees we can provide and whether the feature can destabilize the system.

One possible outcome of alpha2 work is that we may decide to limit the feature to cgroupv2.

Before this is investigated, it's better to keep feature in alpha stage.

/sig node
/assign @dchen1107 @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2022
@rhockenbury rhockenbury mentioned this pull request Oct 1, 2022
60 tasks

- Add e2e tests that exercise all available swap configurations via the CRI.
- Verify MemoryPressure behavior with swap enabled and document any changes
for configuring eviction.
- Verify new system-reserved settings for swap memory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify a little bit on "Verify" here? Manual testing and figure out the work items for beta? Document the changes to guide the users for the alpha feature?

@dchen1107
Copy link
Member

/lgtm
/approve

When you mentioned to have the feature staying at alpha, but move it to alpha2, I didn't understand the reasons. Now I see. There are some unknowns in previous alpha stage (management overhead reservation, security, etc.), while more new changes around the feature (cgroup v2, etc.). Thanks for making sure the feature can be used easier as alpha.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@dchen1107
Copy link
Member

cc/ @mrunalp for vis.

@k8s-ci-robot k8s-ci-robot merged commit eed6b07 into kubernetes:master Oct 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 5, 2022
@SergeyKanzhelev SergeyKanzhelev deleted the updateSwap branch October 5, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants