Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3488: Add PRR and test section for Cel admission control #3554

Merged
merged 6 commits into from
Oct 5, 2022
Merged

KEP-3488: Add PRR and test section for Cel admission control #3554

merged 6 commits into from
Oct 5, 2022

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented Sep 27, 2022

  • One-line PR description: Adding PRR and test section for CEL Admission Control

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 27, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 27, 2022
@cici37 cici37 force-pushed the cel-admission-control branch from 539a87f to 3e008ad Compare September 28, 2022 21:46
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 28, 2022
@cici37 cici37 force-pushed the cel-admission-control branch from 3e008ad to 474bdab Compare September 28, 2022 21:55
@cici37 cici37 force-pushed the cel-admission-control branch 2 times, most recently from 48958f6 to 02c3e42 Compare September 28, 2022 22:40
@cici37 cici37 marked this pull request as ready for review September 28, 2022 22:42
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2022
@jpbetz
Copy link
Contributor

jpbetz commented Sep 28, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2022
@cici37
Copy link
Contributor Author

cici37 commented Sep 29, 2022

/assign @deads2k

sftim
sftim reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits.

keps/sig-api-machinery/3488-cel-admission-control/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/3488-cel-admission-control/README.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2022
@cici37 cici37 assigned johnbelamaric and unassigned deads2k Oct 3, 2022
@cici37 cici37 mentioned this pull request Oct 3, 2022
Open
16 tasks
johnbelamaric
johnbelamaric reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good, just a little more descriptoin on the enable/disable edit resource flow please

@cici37
Copy link
Contributor Author

cici37 commented Oct 3, 2022

looks pretty good, just a little more descriptoin on the enable/disable edit resource flow please

Addressed. Thank you ^^

@johnbelamaric
Copy link
Member

PRR looks good with nit fix, will wait for SIG approval before approving

@jpbetz
Copy link
Contributor

jpbetz commented Oct 4, 2022

/assign @lavalamp @deads2k
for sig approval

@lavalamp
Copy link
Member

lavalamp commented Oct 4, 2022

/approve

@cici37 cici37 force-pushed the cel-admission-control branch from f2c1c86 to bf05607 Compare October 4, 2022 19:27
@cici37
Copy link
Contributor Author

cici37 commented Oct 4, 2022

/hold
Confirming if it is ok to change status to implementable in this PR.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2022
@cici37 cici37 force-pushed the cel-admission-control branch from bf05607 to 130f0b3 Compare October 4, 2022 20:48
@deads2k
Copy link
Contributor

deads2k commented Oct 5, 2022

looks good. I think everything in the first alpha is ready. When the API PRs are opened, I'd like a chance to have a look.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, deads2k, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@cici37
Copy link
Contributor Author

cici37 commented Oct 5, 2022

/unhold
thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4c20efa into kubernetes:master Oct 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 5, 2022
@cici37 cici37 deleted the cel-admission-control branch October 5, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@jpbetz jpbetz jpbetz left review comments

@fedebongio fedebongio Awaiting requested review from fedebongio

@apelisse apelisse Awaiting requested review from apelisse

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@jpbetz jpbetz

@lavalamp lavalamp

@deads2k deads2k

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
7 participants
@cici37 @k8s-ci-robot @jpbetz @johnbelamaric @lavalamp @deads2k @sftim