Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-596: Move GA milestone to 1.25, update PRR #3368

Merged
merged 1 commit into from
Jun 20, 2022
Merged

KEP-596: Move GA milestone to 1.25, update PRR #3368

merged 1 commit into from
Jun 20, 2022

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Jun 8, 2022

  • One-line PR description:
    KEP-596: Move GA milestone to 1.25, update PRR
  • Other comments:

/cc @jsafrane @gnufied @xing-yang @wojtek-t

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jun 8, 2022
@dobsonj dobsonj force-pushed the kep-596-updates-1.25 branch from 5c5ada9 to fc05de5 Compare June 8, 2022 23:37
@dobsonj dobsonj force-pushed the kep-596-updates-1.25 branch from fc05de5 to 7a8fdf0 Compare June 10, 2022 02:47
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2022
@dobsonj dobsonj force-pushed the kep-596-updates-1.25 branch 3 times, most recently from 31f8894 to 82781e3 Compare June 10, 2022 03:16
@wojtek-t wojtek-t self-assigned this Jun 10, 2022
@dobsonj dobsonj force-pushed the kep-596-updates-1.25 branch from 82781e3 to b4200ce Compare June 10, 2022 16:12
@dobsonj dobsonj mentioned this pull request Jun 10, 2022
Closed
@xing-yang
Copy link
Contributor

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 14, 2022
@gnufied
Copy link
Member

gnufied commented Jun 15, 2022

This enhancement narrowly missed implementation last quarter and nothing has changed in the meanwhile from design standpoint.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2022
@jsafrane
Copy link
Member

/lgtm

@wojtek-t
Copy link
Member

/lgtm

@jsafrane
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit d0f8310 into kubernetes:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@gnufied gnufied

@jsafrane jsafrane

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
6 participants
@dobsonj @xing-yang @gnufied @jsafrane @wojtek-t @k8s-ci-robot