Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1432 Move volume health monitoring to beta #3321

Closed
wants to merge 4 commits into from
Closed

KEP-1432 Move volume health monitoring to beta #3321

wants to merge 4 commits into from

Conversation

xing-yang
Copy link
Contributor

  • One-line PR description: Move volume health monitoring to beta
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 28, 2022
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 28, 2022
@xing-yang
Copy link
Contributor Author

/assign @gnufied

@xing-yang
Copy link
Contributor Author

/assign @deads2k

@xing-yang xing-yang force-pushed the volume_health_beta branch from 968dc5e to f4c0345 Compare June 5, 2022 01:06
@xing-yang
Copy link
Contributor Author

@wojtek-t Addressed your comment. Can you help with PRR review?

@xing-yang xing-yang force-pushed the volume_health_beta branch from f4c0345 to af2d1a5 Compare June 9, 2022 00:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2022
@xing-yang xing-yang force-pushed the volume_health_beta branch from af2d1a5 to 78ccf43 Compare June 9, 2022 00:45
@deads2k
Copy link
Contributor

deads2k commented Jun 9, 2022

The detail here is very good, thank you. Approve the PRR, the sig owns /lgtm for the move to beta in this release.

/approve

1 similar comment
@deads2k
Copy link
Contributor

deads2k commented Jun 9, 2022

The detail here is very good, thank you. Approve the PRR, the sig owns /lgtm for the move to beta in this release.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Jun 11, 2022
Open
9 tasks
@xing-yang xing-yang force-pushed the volume_health_beta branch from 78ccf43 to 230a409 Compare June 24, 2022 02:55
@xing-yang xing-yang mentioned this pull request Jul 12, 2022
Merged
@pohly
Copy link
Contributor

pohly commented Aug 8, 2022

Have the questions around scalability of this feature from kubernetes-csi/external-health-monitor#91 (comment) been addressed?

@pohly
Copy link
Contributor

pohly commented Aug 8, 2022

Open issues:

@pohly
Copy link
Contributor

pohly commented Aug 8, 2022

Where are E2E tests for this feature (one of the beta graduation criteria)?

@xing-yang
Copy link
Contributor Author

xing-yang commented Sep 12, 2022 •
edited
Loading

Where are E2E tests for this feature (one of the beta graduation criteria)?

The e2e tests for this feature is being worked on. This feature will not move to Beta if the e2e tests can't be merged before the KEP merge deadline.
By the way, the e2e test will only be added for the feature on the node side. It will not be added for the feature on the controller side because we can't rely on events in the test as events can disappear. I pointed this out in the KEP as well.

@xing-yang
Copy link
Contributor Author

Have the questions around scalability of this feature from kubernetes-csi/external-health-monitor#91 (comment) been addressed?

Thanks for the reminder. Someone is working on it but it is not complete yet. This issue is on the controller side.

@fengzixu fengzixu mentioned this pull request Nov 20, 2022
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2023
@xing-yang
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2023
@marosset marosset changed the title Move volume health monitoring to beta KEP-1432 Move volume health monitoring to beta Feb 9, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 10, 2023
@carlory
Copy link
Member

carlory commented May 17, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 17, 2023
carlory
carlory reviewed May 29, 2023
View reviewed changes
keps/sig-storage/1432-volume-health-monitor/kep.yaml
@@ -20,12 +20,12 @@ approvers:
see-also:
replaces:

latest-milestone: "v1.24"
stage: "alpha"
latest-milestone: "v1.27"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.28 for beta, right?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 18, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mowangdk mowangdk mentioned this pull request May 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory carlory left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@rhockenbury rhockenbury rhockenbury left review comments

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@gnufied gnufied

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@xing-yang @deads2k @k8s-ci-robot @pohly @k8s-triage-robot @carlory @rhockenbury @wojtek-t @gnufied