Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KEP-3022 based on the latest implementation #3245

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

sanposhiho
Copy link
Member

  • One-line PR description: Update KEP-3022 based on the latest implementation
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 19, 2022
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g March 19, 2022 15:59
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Mar 19, 2022
@k8s-ci-robot k8s-ci-robot requested a review from Huang-Wei March 19, 2022 15:59
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Mar 19, 2022
@sanposhiho sanposhiho mentioned this pull request Mar 19, 2022
12 tasks
@alculquicondor
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@alculquicondor
Copy link
Member

If the API changes are not significant and don't change the behavior of the feature, we generally don't update the KEP.

@k8s-ci-robot k8s-ci-robot merged commit 7599e38 into kubernetes:master Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 21, 2022
@sanposhiho
Copy link
Member Author

If the API changes are not significant and don't change the behavior of the feature, we generally don't update the KEP.

Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants