KEP-3031: Add release artifact signing KEP #3061
Conversation
saschagrunert
commented
Nov 29, 2021
saschagrunert
commented
- One-line PR description: adding initial draft of the artifact signing enhancement
- Issue link: Signing Release Artifacts #3031
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/release
saschagrunert
force-pushed
the
signing-release-artifacts
branch
2 times, most recently
from
65d63c4
to
d661be0
Compare
There was a problem hiding this comment.
Nice to see this in, thank you @saschagrunert ! Some notes to consider:
saschagrunert
force-pushed
the
signing-release-artifacts
branch
3 times, most recently
from
c14cad0
to
20b944a
Compare
saschagrunert
force-pushed
the
signing-release-artifacts
branch
from
20b944a
to
ece96d2
Compare
|
/assign @justaugustus @cpanato |
Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
signing-release-artifacts
branch
from
ece96d2
to
2099733
Compare
| pre-evaluation of the tool has been done already to ensure that it meets the | ||
| requirements. | ||
|
|
||
| An [ongoing discussion](https://github.com/kubernetes/release/issues/2227) about |
There was a problem hiding this comment.
Would be a great pioneering use case for sigstore trust delegations!
There was a problem hiding this comment.
@trishankatdatadog Unfortunately, I don't have access to this document. Is this anything we have to consider for this KEP?
There was a problem hiding this comment.
No, I don't think so, I think that's for another KEP that details the specifics of signing and verification. It can be done with cosign in any case, which you have already mentioned here.
There was a problem hiding this comment.
No, I don't think so, I think the details can go into the specific KEP that details signing/verification. Thanks!
There was a problem hiding this comment.
Great work here, @saschagrunert!
/lgtm
/approve
Hold to removed at EOD.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Starting the first implementation in kubernetes/release#2383 |
