Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2400: Rename feature flag to NodeSwap #2815

Merged
merged 1 commit into from
Aug 12, 2021
Merged

KEP-2400: Rename feature flag to NodeSwap #2815

merged 1 commit into from
Aug 12, 2021

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Jul 8, 2021

  • One-line PR description: Renames feature flag to NodeSwap from NodeSwapEnabled

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2021
@sftim
Copy link
Contributor

sftim commented Jul 8, 2021

/hold
Waiting on kubernetes/kubernetes#103553
LGTM

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2021
@ehashman
Copy link
Member Author

/hold cancel

PR merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Jul 13, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2021
@ehashman ehashman mentioned this pull request Jul 14, 2021
Merged
@justaugustus
Copy link
Member

justaugustus commented Aug 12, 2021 •
edited
Loading

/lgtm
/approve
xref: https://kubernetes.slack.com/archives/C1L57L91V/p1628801264003000

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, justaugustus, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 59a1941 into kubernetes:master Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@mrunalp mrunalp

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
5 participants
@ehashman @sftim @mrunalp @justaugustus @k8s-ci-robot