Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-2133]: Update milestone and metadata for Kubelet credential provider #2675

Merged
merged 1 commit into from
May 13, 2021
Merged

[KEP-2133]: Update milestone and metadata for Kubelet credential provider #2675

merged 1 commit into from
May 13, 2021

Conversation

adisky
Copy link
Contributor

@adisky adisky commented May 5, 2021

Updates the KEP to target Beta for 1.22

/sig node cloud-provider auth

Signed-off-by: Aditi Sharma [email protected]

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 5, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2021
@adisky
Copy link
Contributor Author

adisky commented May 5, 2021

/cc @andrewsykim

@k8s-ci-robot k8s-ci-robot requested a review from andrewsykim May 5, 2021 09:24
@adisky adisky force-pushed the update-credential-provider-KEP branch from 0840d9f to 9261fa3 Compare May 5, 2021 09:44
@adisky
Update metdata for KEP-2133
0ad4f18 
Signed-off-by: Aditi Sharma <[email protected]>
@adisky adisky force-pushed the update-credential-provider-KEP branch from 9261fa3 to 0ad4f18 Compare May 5, 2021 09:54
andrewsykim
andrewsykim reviewed May 7, 2021
View reviewed changes
keps/sig-node/2133-kubelet-credential-providers/kep.yaml

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.20"
beta: "v1.21"
stable: "v1.23"
beta: "v1.22"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For added context, during the v1.21 cycle, the Beta criteria and PRR was already filled out as part of #2457, but we never got around to following through on the implementation. So in v1.22, I think the milestone updates are enough, in addition to the minor updates @adisky already added.

@andrewsykim
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@deads2k
Copy link
Contributor

deads2k commented May 7, 2021 •
edited
Loading

PRR still lgtm (I'm going through my assignee list this release)

/approve

@JamesLaverack
Copy link
Member

xref #2133

@JamesLaverack JamesLaverack mentioned this pull request May 11, 2021
Closed
4 tasks
@enj
Copy link
Member

enj commented May 11, 2021

This seems fine from a sig-auth perspective.

@adisky
Copy link
Contributor Author

adisky commented May 12, 2021

/cc @dchen1107 @derekwaynecarr @ehashman @SergeyKanzhelev

@SergeyKanzhelev
Copy link
Member

/lgtm

@mrunalp
Copy link
Contributor

mrunalp commented May 13, 2021

/approve
cc: @derekwaynecarr

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky, dchen1107, deads2k, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 06737ed into kubernetes:master May 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@ehashman ehashman Awaiting requested review from ehashman

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
9 participants
@adisky @andrewsykim @deads2k @JamesLaverack @enj @SergeyKanzhelev @mrunalp @dchen1107 @k8s-ci-robot