-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2104: kube-proxy v2: reworking the proxy's architecture #2094
Conversation
Welcome @mcluseau! |
Hi @mcluseau. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I like it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this first review, it's really nice to have external viewpoints :)
This KEP is born from the conviction that more decoupling of the Service object and the actual implementations is required, | ||
by introducing an intermediate, node-level abstaction provider. This abstraction is expected to be the result of applying | ||
Kubernetes' `Service` semantics and business logic to a simpler, more stable API. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, good example of the interest of the decoupling I'm trying to achieve. Same idea with adding the topology concept.
keps/sig-network/2104-reworking-kube-proxy-architecture/README.md
Outdated
Show resolved
Hide resolved
/cc |
keps/sig-network/2104-reworking-kube-proxy-architecture/README.md
Outdated
Show resolved
Hide resolved
That's next Monday, yes? I am in.
…On Wed, Dec 9, 2020 at 1:52 PM Mikaël Cluseau ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In keps/sig-network/2104-reworking-kube-proxy-architecture/README.md
<#2094 (comment)>
:
> +
+<!--
+This is where we get down to the specifics of what the proposal actually is.
+This should have enough detail that reviewers can understand exactly what
+you're proposing, but should not include things like API designs or
+implementation. The "Design Details" section below is for the real
+nitty-gritty.
+-->
+
+Rewrite the kube-proxy to be a "localhost" gRPC API provider that will be accessible as usual via
+TCP (`127.0.0.1:12345`) and/or via a socket (`unix:///path/to/proxy.sock`).
+
+- it will connect to the API server and watch resources, like the current proxy;
+- then, it will process them, applying Kubernetes specific business logic like topology computation
+ relative to the local host;
+- finally, provide the result of this computation to client via a gRPC watchable API.
update: the best choice is currently on 14th at 22:30 UTC (14:30 PST)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#2094 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVAP56SDRVRNV4OHSETST7WSFANCNFSM4SLLSI3Q>
.
|
That should work for me also. Let me know the invite details. |
Works for me. |
yes, it's next monday, I'll post the link. I'll use meet unless there's a strong preference for zoom. |
@mcluseau is this still on for today? Is there any info on the meeting address? |
@howardjohn yes it's still today, I'll post the link here in 3h (30 min before the meeting) |
hi all, meeting link: meet.google.com/jjf-szrn-qre |
Were going to break this KEP into 3 sections , per conv w others today in sig-network
Then we'll resubmit to Sig-network |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@knabben: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mcluseau The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/lifecycle frozen |
@liangyuanpeng: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Time to close this now? I think the nftables KEP supersedes. |
Hi folks,
I started the process of writing the KEP for my proposal of a "kube-proxy v2", and I think I'm ready to get some early comments. Thanks in advance for kind reviews and ideas :-)
@thockin