Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding kep.yaml for windows-cri-containerd KEP #2038

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Adding kep.yaml for windows-cri-containerd KEP #2038

merged 1 commit into from
Oct 1, 2020

Conversation

marosset
Copy link
Contributor

Adding kep.yaml for windows-cri-containerd KEP

#1001

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/windows Categorizes an issue or PR as relevant to SIG Windows. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2020
@marosset
Copy link
Contributor Author

@MorrisLaw Here is the PR to add a kep.yaml for this KEP.
What would you recommend I add for the kep number? should i keep the date string from the old kep format or create a new number for this?

@marosset marosset force-pushed the windows-containerd-1.20 branch 2 times, most recently from ad5212d to d88ac85 Compare September 30, 2020 18:47
@kikisdeliveryservice
Copy link
Member

@marosset
Should be the issue number : 1001-windows-cri...

But you also need to delete the header in the README.md as that info is now contained in kep.yaml https://github.com/kubernetes/enhancements/blob/d88ac8550fe79fd671a4ed4bfc74bdb1649dbbe1/keps/sig-windows/20190424-windows-cri-containerd/README.md

See templates for ref: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

@marosset marosset force-pushed the windows-containerd-1.20 branch from d88ac85 to e4a7ef1 Compare October 1, 2020 22:34
@marosset
Copy link
Contributor Author

marosset commented Oct 1, 2020

/test pull-enhancements-verify

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 1, 2020 •
edited
Loading

@marosset you still have to update the dir name =)

1001-windows-cri....

@marosset marosset force-pushed the windows-containerd-1.20 branch from e4a7ef1 to aeaa314 Compare October 1, 2020 22:46
@marosset
Copy link
Contributor Author

marosset commented Oct 1, 2020

doh...

@marosset
Copy link
Contributor Author

marosset commented Oct 1, 2020

Updated 😃

@marosset
Copy link
Contributor Author

marosset commented Oct 1, 2020

/assign @michmike

@kikisdeliveryservice
Copy link
Member

Updated smiley

YES! That's it! 👍

michmike
michmike approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@michmike michmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
let's do this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, michmike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9b76470 into kubernetes:master Oct 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michmike michmike michmike approved these changes

@benmoss benmoss Awaiting requested review from benmoss

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@michmike michmike

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@marosset @kikisdeliveryservice @k8s-ci-robot @michmike