Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar: Address all concerns raised #1980

Merged
merged 16 commits into from
Oct 21, 2020
Merged

sidecar: Address all concerns raised #1980

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ebd059c
sidecar: Remove old phrase in non-goals
rata Sep 4, 2020
c8469da
sidecar: Clarify all sidecars start in parallel
rata Sep 4, 2020
b71de79
sidecar: Don't modify the pod phase
rata Sep 4, 2020
693c4c2
sidecar: Don't send preStop hook twice
rata Sep 9, 2020
2badf86
sidecar: Address handling of the pod=nil case
rata Sep 9, 2020
95c588e
sidecar: Move some sections to caveats
rata Sep 9, 2020
9a6a367
sidecar: Remove addressed concerns
rata Sep 9, 2020
b6214c9
sidecar: Document increased time to kill a pod in the worst case
rata Sep 9, 2020
2a17744
sidecar: Address concern about kill time 3x longer
rata Sep 9, 2020
58590b7
sidecar: Mention it solves jobs with sidecars
rata Sep 9, 2020
0c5b731
sidecar: Add clarifications from Istio devs
rata Sep 10, 2020
999fda3
sidecar: Trivial clarification
rata Sep 10, 2020
d917695
sidecar: Update PoC implementation note
rata Sep 10, 2020
8ad75f2
sidecar: Merge "Implementation Details" and "Design Details" sections
rata Sep 10, 2020
4409f9d
sidecar: Update TOC
rata Sep 10, 2020
25089fb
sidecar: Remove type Standard
rata Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading