Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1693: Update warnings KEP with 1.19 work #1958

Merged
merged 1 commit into from
Sep 14, 2020
Merged

KEP-1693: Update warnings KEP with 1.19 work #1958

merged 1 commit into from
Sep 14, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 29, 2020 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Aug 29, 2020
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 29, 2020
@liggitt liggitt force-pushed the warning-implementation branch from c914b4d to 20b4464 Compare August 29, 2020 14:28
@liggitt liggitt force-pushed the warning-implementation branch from 20b4464 to 4d00796 Compare August 29, 2020 14:32
@deads2k
Copy link
Contributor

deads2k commented Sep 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2020
@deads2k
Copy link
Contributor

deads2k commented Sep 14, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit fe2fa0a into kubernetes:master Sep 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 14, 2020
@liggitt liggitt deleted the warning-implementation branch January 6, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@fedebongio fedebongio Awaiting requested review from fedebongio

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @deads2k @k8s-ci-robot