sidecar: Add dependency and mark as provisional #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/apps
This commit just marks the KEP as provisional, adds a dependency on the kubelet node shutdown work that is coming and, while we are there, renames it to use the existing issue tracking number. Signed-off-by: Rodrigo Campos <[email protected]>
As discussed in SIG-node meeting, on June 30 2020, adding approvers and reviewers.
|
Added approvers and reviewers as we talked about in SIG-node today. Please let me know if you think someone should be removed, I understand the KEP started 2 years ago and maybe the same people is not still available :) |
|
/assign @derekwaynecarr |
|
/assign @dashpole @dchen1107 |
|
I think this can be further revised once the shutdown kep is presented. We may adjust timelines in light of both proposals. This captures the discussion in SIG Node, and so is an incremental improvement on clarifying next steps for everyone that finds the KEP. Thanks @rata for identifying the challenges you raised in the SIG while exploring the concept further. /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, rata The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thank you all! :) |
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 23, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 23, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 23, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 23, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 23, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 23, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 24, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 24, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 24, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 27, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 29, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 29, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 29, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment)
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 29, 2020
As suggested by @derekwaynecarr here: kubernetes#1874 (comment) Reviewed-by: Joseph-Irving <[email protected]> Signed-off-by: Rodrigo Campos <[email protected]>
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 29, 2020
As suggested by derekwaynecarr here: kubernetes#1874 (comment) Reviewed-by: Joseph-Irving <[email protected]> Signed-off-by: Rodrigo Campos <[email protected]>
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Jul 29, 2020
As suggested by derekwaynecarr here: kubernetes#1874 (comment) Reviewed-by: Joseph-Irving <[email protected]> Signed-off-by: Rodrigo Campos <[email protected]>
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Aug 14, 2020
As suggested by derekwaynecarr here: kubernetes#1874 (comment) Reviewed-by: Joseph-Irving <[email protected]> Signed-off-by: Rodrigo Campos <[email protected]>
rata
added a commit
to kinvolk/kubernetes-enhancements
that referenced
this pull request
Sep 2, 2020
As suggested by derekwaynecarr here: kubernetes#1874 (comment) Reviewed-by: Joseph-Irving <[email protected]> Signed-off-by: Rodrigo Campos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit just marks the KEP as provisional, adds a dependency on the
kubelet node shutdown work that is coming and, while we are there,
renames it to use the existing issue tracking number.
Signed-off-by: Rodrigo Campos [email protected]
As we talked during last SIG-node meeting (June 23 2020), this updates the sidecar KEP. As we talked too, other PRs will follow to highlight some tricky cases I've identified in this KEP (so we can discuss what we want to do and address all concerns), other more general alternatives and why they were discarded, etc. For that reason, all checks are removed now, as I understand we want to review this in detail again and adjust.
We didn't talk about how the dependency should be, so here I propose this (better explained in the PR): sidecar to graduate to beta needs to have kubelet graceful shutdown on beta too, sidecar KEP to graduate to GA needs to have kubelet graceful shutdown on GA for at least 1 release.
Tagging you, @derekwaynecarr, as you we talked on SIG-node meeting :)
Also, I realize we didn't talk about reviewers and approvers. Should I mark you for now, @derekwaynecarr ? Do you have any thoughts?
Thanks again for all your time and help!
cc @Joseph-Irving as he will be helping too and is the original author of this KEP :)
PS: When/if this is merged, I'll update the tracking issue with the current status. I just prefer to wait as there are ton of people watching there and update after someone confirms this PR looks good and I'm not missing something.