KEP-0661: StatefulSet volume resize #1848

kk-src · 2020-06-08T22:09:28Z

StatefulSet volume resize
This enhancement proposes to add the ability to resize volumes associated with StatefulSet via modifications to it's specification.

StatefulSet via modifications to it's specification.

Feature tracking issue: #661

Modified and updated version of #660

k8s-ci-robot · 2020-06-08T22:09:36Z

Welcome @kk-src!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-06-08T22:09:36Z

Hi @kk-src. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-06-08T22:09:45Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kk-src
To complete the pull request process, please assign jsafrane
You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

keps/sig-storage/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kk-src · 2020-06-08T22:11:06Z

/sig apps

kk-src · 2020-06-08T22:12:14Z

/cc @gnufied @kow3ns @msau42

kk-src · 2020-06-08T22:14:26Z

/cc @SidakM-zz

k8s-ci-robot · 2020-06-08T22:14:27Z

@kk-src: GitHub didn't allow me to request PR reviews from the following users: SidakM-zz.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @SidakM-zz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kow3ns

The remaining sections need to be filled out.
We need to think about remediating failure conditions and community user errors when the PVC update fails. We need to think more closely around concurrent and sequential mutations to other part's of the spec and how this interacts with reconciliation during a rollout (replicas, podTemplate). Also how would you deal with storage providers that implement online file system resizing (Imo we should just use an "immutable infra" approach and destroy and recreate the Pod when its volume is resized, but that is just my opinion).

kow3ns · 2020-06-11T00:55:46Z

keps/sig-storage/0661-statefulset-volume-resize/README.md

+The following changes are proposed to achieve the goal:
+1. Make the `volumeClaimTemplates` storage size editable by modification to the api server 
+   validation.
+2. Add reconciliation of the associated PVC's size and the individual `volumeClaimTemplates` 


Consider indicating that we will need to add general PVC syncing.

kow3ns · 2020-06-11T00:56:17Z

keps/sig-storage/0661-statefulset-volume-resize/README.md

+
+Currently, PVC resize does not support shrinking the volume. Also, some environments require Pod restarts inorder 
+to get access to the resized volume. This proposal does not try to address these scenarios but relies on the 
+underlying PVC resize logic to take the appropriate action or indicate error as needed.


Should call out that modifying the storage class of the volumeClaimsTemplate is a non-goal as well.

Thank you, @kow3ns. Will add this.

kow3ns · 2020-06-11T00:58:04Z

keps/sig-storage/0661-statefulset-volume-resize/README.md

+
+### Risks and Mitigations
+
+Currently, shrinking the PVC size is not supported and the same will apply to StatefulSet changes. There 


Consider implementing the validation in the API Machinery. If shrinking the volume will not be supported then the validation for volumesClaimTemplate field should explicitly reject the mutation.

kow3ns · 2020-06-11T21:03:49Z

keps/sig-storage/0661-statefulset-volume-resize/README.md

+the corresponding PVC events. StatefulSet would only report any failures in the update operation 
+performed to the PVC object.
+
+### Revision control


So this has some implications for rollback and failure detection. This needs more thought. If we modify the volume size and the controller wedges midway in the rollout due to a failure, what would the remediation strategy be? There is no roll back to a previous revision. If the user modifies the spec of the StatefulSet to have the smaller volume size to attempt a rollback, that will not be possible either (i.e. no shrinking).

Not true shrinking but a mechanism to allow user to cancel a previously issued volume expansion is in works - #1790 . This requires users to reduce PVC size to previous capacity if they want to cancel the expansion.

gnufied · 2020-07-29T21:54:22Z

/ok-to-test

gnufied · 2020-07-29T22:30:55Z

paging Jordan since he previously reviewed similar KEP.

/assign @liggitt

fejta-bot · 2020-10-27T22:38:40Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2020-11-26T23:22:18Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

msau42 · 2020-12-01T01:32:17Z

/remove-lifecycle rotten

fejta-bot · 2021-03-01T02:10:56Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

gnufied · 2021-03-01T19:23:41Z

/remove-lifecycle stale

fejta-bot · 2021-05-30T19:37:01Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

iTaybb · 2021-05-30T19:52:48Z

This is still relevant.

…

On Sun, May 30, 2021, 22:37 fejta-bot ***@***.***> wrote: Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to sig-contributor-experience at kubernetes/community <https://github.com/kubernetes/community>. /lifecycle stale — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1848 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA3SSBXHAB3BA35PIXJ5F4DTQKHWVANCNFSM4NYZ6UNQ> .

nunosilva800 · 2021-06-01T14:09:01Z

/remove-lifecycle stale

cndoit18 · 2021-06-01T14:11:25Z

For me, it was much needed. 👍

k8s-triage-robot · 2021-08-30T15:02:36Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

iTaybb · 2021-08-30T17:58:57Z

/remove-lifecycle stale

m-yosefpor · 2021-09-22T10:50:36Z

should we close this in favor of #2842 ?

xing-yang · 2021-09-23T14:04:17Z

should we close this in favor of #2842 ?

I checked with @kk-src earlier and he is fine to have this KEP closed and a new KEP submitted.

KEP-0661: StatefulSet volume resize

b9f5fe4

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2020

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 8, 2020

k8s-ci-robot requested review from msau42 and saad-ali June 8, 2020 22:09

k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jun 8, 2020

k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jun 8, 2020

k8s-ci-robot requested review from gnufied and kow3ns June 8, 2020 22:12

kow3ns reviewed Jun 11, 2020

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2020

k8s-ci-robot assigned liggitt Jul 29, 2020

cofyc mentioned this pull request Jul 30, 2020

Patch PVC when storage request is increased pingcap/tidb-operator#3004

Closed

WolfspiritM mentioned this pull request Sep 14, 2020

Support expansion of PVCs mongodb/mongodb-kubernetes-operator#197

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 26, 2020

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 1, 2020

btlyken mentioned this pull request Jan 22, 2021

StatefulSet: support resize pvc storage in K8s v1.11 kubernetes/kubernetes#68737

Open

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 1, 2021

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 1, 2021

hochuenw-dd mentioned this pull request Apr 13, 2021

Helm chart deployment with volumeClaimTemplates apache/pinot#6780

Open

cndoit18 mentioned this pull request May 21, 2021

Support volume resize bitpoke/mysql-operator#684

Open

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 30, 2021

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 1, 2021

ymmt2005 mentioned this pull request Jun 21, 2021

Document the procedure to increase volume size cybozu-go/moco#265

Closed

4 tasks

shalini-b mentioned this pull request Jul 28, 2021

KEP-0661: StatefulSet volume resize #2842

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2021

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2021

xing-yang closed this Sep 23, 2021

areller mentioned this pull request Jun 19, 2022

KEP-0661: StatefulSet volume resize #3412

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KEP-0661: StatefulSet volume resize #1848

KEP-0661: StatefulSet volume resize #1848

kk-src commented Jun 8, 2020

k8s-ci-robot commented Jun 8, 2020

k8s-ci-robot commented Jun 8, 2020

k8s-ci-robot commented Jun 8, 2020

kk-src commented Jun 8, 2020 •

edited

Loading

kk-src commented Jun 8, 2020

kk-src commented Jun 8, 2020

k8s-ci-robot commented Jun 8, 2020

kow3ns left a comment

kow3ns Jun 11, 2020

kow3ns Jun 11, 2020

kk-src Jun 12, 2020

kow3ns Jun 11, 2020

kow3ns Jun 11, 2020 •

edited

Loading

gnufied Jul 29, 2020

gnufied commented Jul 29, 2020

gnufied commented Jul 29, 2020

fejta-bot commented Oct 27, 2020

fejta-bot commented Nov 26, 2020

msau42 commented Dec 1, 2020

fejta-bot commented Mar 1, 2021

gnufied commented Mar 1, 2021

fejta-bot commented May 30, 2021

iTaybb commented May 30, 2021 via email

nunosilva800 commented Jun 1, 2021

cndoit18 commented Jun 1, 2021

k8s-triage-robot commented Aug 30, 2021

iTaybb commented Aug 30, 2021

m-yosefpor commented Sep 22, 2021

xing-yang commented Sep 23, 2021


		### Risks and Mitigations

		Currently, shrinking the PVC size is not supported and the same will apply to StatefulSet changes. There

KEP-0661: StatefulSet volume resize #1848

KEP-0661: StatefulSet volume resize #1848

Conversation

kk-src commented Jun 8, 2020

k8s-ci-robot commented Jun 8, 2020

k8s-ci-robot commented Jun 8, 2020

k8s-ci-robot commented Jun 8, 2020

kk-src commented Jun 8, 2020 • edited Loading

kk-src commented Jun 8, 2020

kk-src commented Jun 8, 2020

k8s-ci-robot commented Jun 8, 2020

kow3ns left a comment

Choose a reason for hiding this comment

kow3ns Jun 11, 2020

Choose a reason for hiding this comment

kow3ns Jun 11, 2020

Choose a reason for hiding this comment

kk-src Jun 12, 2020

Choose a reason for hiding this comment

kow3ns Jun 11, 2020

Choose a reason for hiding this comment

kow3ns Jun 11, 2020 • edited Loading

Choose a reason for hiding this comment

gnufied Jul 29, 2020

Choose a reason for hiding this comment

gnufied commented Jul 29, 2020

gnufied commented Jul 29, 2020

fejta-bot commented Oct 27, 2020

fejta-bot commented Nov 26, 2020

msau42 commented Dec 1, 2020

fejta-bot commented Mar 1, 2021

gnufied commented Mar 1, 2021

fejta-bot commented May 30, 2021

iTaybb commented May 30, 2021 via email

nunosilva800 commented Jun 1, 2021

cndoit18 commented Jun 1, 2021

k8s-triage-robot commented Aug 30, 2021

iTaybb commented Aug 30, 2021

m-yosefpor commented Sep 22, 2021

xing-yang commented Sep 23, 2021

kk-src commented Jun 8, 2020 •

edited

Loading

kow3ns Jun 11, 2020 •

edited

Loading