Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Structured Logging KEP into implementable state #1617

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Move Structured Logging KEP into implementable state #1617

merged 1 commit into from
Mar 16, 2020

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Mar 16, 2020 •
edited
Loading

This PR moves Structured Logging KEP into implementable state and does some minor fixes.

/assign @brancz
Can you approve changing of KEP state into "implementable"?

@k8s-ci-robot k8s-ci-robot requested a review from brancz March 16, 2020 16:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Mar 16, 2020
@serathius
Copy link
Contributor Author

/cc @44past4

@k8s-ci-robot k8s-ci-robot requested a review from 44past4 March 16, 2020 16:18
@brancz
Copy link
Member

brancz commented Mar 16, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 53e87d7 into kubernetes:master Mar 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 16, 2020
@dims dims mentioned this pull request Apr 15, 2020
Merged
14 tasks
@seanmalloy seanmalloy mentioned this pull request May 20, 2020
Closed
@abhiraut abhiraut mentioned this pull request May 21, 2020
Closed
@davidvonthenen davidvonthenen mentioned this pull request Dec 8, 2020
Merged
RomanBednar pushed a commit to RomanBednar/enhancements that referenced this pull request Jul 30, 2024
@openshift-merge-bot
Merge pull request kubernetes#1617 from mresvanis/image-based-installer
15c2138 
MGMT-17600: Add image-based installer enhancement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz Awaiting requested review from brancz

@44past4 44past4 Awaiting requested review from 44past4

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
3 participants
@serathius @brancz @k8s-ci-robot