Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking node label for OS version complete in 1.17 #1484

Merged
merged 1 commit into from
Jan 21, 2020
+4 −2
Merged

Marking node label for OS version complete in 1.17 #1484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions keps/sig-windows/windows-runtimeclass-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ see-also:
- [Story 2 - Forward compatibility with Hyper-V](#story-2---forward-compatibility-with-hyper-v)
- [Story 3 - Choosing a specific multi-arch image](#story-3---choosing-a-specific-multi-arch-image)
- [Implementation Details/Notes/Constraints](#implementation-detailsnotesconstraints)
- [Adding new label node.kubernetes.io/windows-build](#adding-new-label-nodekubernetesiowindows-build)
- [Adding new label node.kubernetes.io/windows-build (done)](#adding-new-label-nodekubernetesiowindows-build-done)
- [Adding handler to CRI pull API](#adding-handler-to-cri-pull-api)
- [Risks and Mitigations](#risks-and-mitigations)
- [Adding new node label](#adding-new-node-label)
Expand Down Expand Up @@ -265,7 +265,9 @@ Here's an example of what corresponding ContainerD configurations could look lik

There were multiple options discussed with SIG-Node & SIG-Windows on October 8 2019 prior to filing this KEP. That discussion & feedback were captured in [Difficulties in mixed OS and arch clusters]. If you're looking for more details on other approaches excluded, please review that document.

#### Adding new label node.kubernetes.io/windows-build
#### Adding new label node.kubernetes.io/windows-build (done)

> Done. This label was added in Kubernetes 1.17

In [Bounding Self-Labeling Kubelets], a specific range of prefixes were reserved for node self-labeling - `[*.]node.kubernetes.io/*`. Adding a new label within that namespace won't require any changes to NodeRestriction admission. As a new field it also won't require changes to any existing workloads.

Expand Down