Apply KEP: Document toplogy #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
apelisse
force-pushed
the
apply-topology
branch
from
88ec826 to
1eb21ca
Compare
apelisse
force-pushed
the
apply-topology
branch
from
1eb21ca to
61f326f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
lavalamp
reviewed
Oct 21, 2019
| `"x-kubenetes-list-type": "map"` along with `// | ||
| +x-kubernetes-list-map-key=name`, or `"listMapKey": "name"`. Items | ||
| of an associative lists are owned by the person who applied the item to the | ||
| list. |
There was a problem hiding this comment.
We've left out "lists where the index is a reasonable key" -- I think we'll eventually want this, but not right now. (not asking for a change)
lavalamp
reviewed
Oct 21, 2019
| but can be explicitly specified with `// +mapType=separate` or `// | ||
| +structType=separate` respectively. They map to the same openapi extension: | ||
| `x-kubernetes-map-type=separate`. | ||
| - All the fields or item of the map are treated as one, we say the map/struct is |
|
/approve (one tiny nit, anyone can lgtm once fixed) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, kwiesmueller, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve KEP by adding topology description
/cc @kwiesmueller @jennybuckley @lavalamp