Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal moving ExternalDNS into Kubernetes organization #1247

Merged
merged 6 commits into from
Nov 15, 2019

Conversation

njuettner
Copy link
Member

A proposal to move ExternalDNS out of kubernetes-incubator and move it into the Kubernetes organization.

@k8s-ci-robot
Copy link
Contributor

Welcome @njuettner!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @njuettner. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2019
@njuettner
Copy link
Member Author

/assign @dcbw

@njuettner
Copy link
Member Author

Any feedback for us? It would be nice if someone could look at it. Highly appreciate your feedback 🙂 @thockin @caseydavenport @dcbw

@mrbobbytables
Copy link
Member

Hey there @njuettner Just an FYI - you don't actually need to make a KEP to migrate a repo across kubernetes orgs 👍

The Kubernetes incubator org has been deprecated and there's an outstanding issue about migrating the various repos to the kubernetes-sigs org.

To initiate it, it'd be best to send a message to the owning sig mailing list to get broader buy-in regarding the move. After that, it's filing a New Repo / Migrate Repo request in the kubernetes/org repo.

Hope that helps!

@njuettner
Copy link
Member Author

@mrbobbytables thank you for your reply. We didn't know about that and thought it would be a good idea to write a KEP.

I was writing to sig-network mailing group before and they were so nice to answer my question to create a PR first so that it can be approved.

This was brought up a couple months ago as I recall. The next step was a KEP - I see there is one in the external DNS project. The intent would be to put one in k/enhancements where it would be seen by others and could be approved by the SIG.

Can you send a PR with that KEP to k/enhancements - specifically here: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network

Then we can comment and hopefully approve once it's to everyone's satisfaction.

See: https://groups.google.com/forum/#!topic/kubernetes-sig-network/KOpzXgWcCMA

So I'm a bit lost now what I need to do, if it's only creating a new issue to migrate the project I'm happy to do that.

@mrbobbytables
Copy link
Member

So I'm a bit lost now what I need to do, if it's only creating a new issue to migrate the project I'm happy to do that.

Hm, it may be worth getting it on the agenda for an upcoming sig-network meeting to get everything sorted out.

@Raffo
Copy link

Raffo commented Oct 10, 2019

@mrbobbytables @njuettner just for completeness, this is where I was asked to write a KEP: https://groups.google.com/d/msg/kubernetes-sig-network/fvpDC_nxtEM/lmn4ksWaBgAJ

After some work, that got merged in the ExternalDNS repo to eventually create this enhancement request.

@bowei
Copy link
Member

bowei commented Oct 15, 2019

This makes sense -- you should definitely advertise this in sig-network call if possible to get the ACKs needed to move the project.

@bowei
Copy link
Member

bowei commented Oct 15, 2019

/assign bowei@

@njuettner
Copy link
Member Author

/assign bowei

@bowei
Copy link
Member

bowei commented Oct 26, 2019

/lgtm

@thockin

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2019
@bowei
Copy link
Member

bowei commented Oct 26, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@bowei
Copy link
Member

bowei commented Nov 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2019
@bowei
Copy link
Member

bowei commented Nov 4, 2019

@thockin this is already done, we should /approve and merge

@bowei
Copy link
Member

bowei commented Nov 8, 2019

ping

@thockin @caseydavenport this is already done -- we should merge this for historical purposes.

@thockin
Copy link
Member

thockin commented Nov 15, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, njuettner, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 22ecc8d into kubernetes:master Nov 15, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 15, 2019
spiffxp added a commit to spiffxp/enhancements that referenced this pull request Sep 23, 2021
I chose approvers for the KEP that needed modifcation by plumbing
through git history and looking at
kubernetes#1247 which introduced
the original KEP
hh pushed a commit to ii/keps that referenced this pull request Dec 7, 2021
I chose approvers for the KEP that needed modifcation by plumbing
through git history and looking at
kubernetes#1247 which introduced
the original KEP
rikatz pushed a commit to rikatz/enhancements that referenced this pull request Feb 1, 2022
I chose approvers for the KEP that needed modifcation by plumbing
through git history and looking at
kubernetes#1247 which introduced
the original KEP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants