Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HugePages #751

Closed
derekwaynecarr opened this issue Jan 29, 2019 · 12 comments
Closed

HugePages #751

derekwaynecarr opened this issue Jan 29, 2019 · 12 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@derekwaynecarr
Copy link
Member

Enhancement Description: HugePages to GA

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 29, 2019
@derekwaynecarr
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 29, 2019
@vishh
Copy link
Contributor

vishh commented Jan 29, 2019

@derekwaynecarr do we have adequate metrics exposed to track the health of huge pages functionality in Kubelet? If yes, it would be great if you can list them here (or ideally in user docs) for easier reference in the future

@derekwaynecarr derekwaynecarr added this to the v1.14 milestone Jan 29, 2019
@claurence
Copy link

@derekwaynecarr since therKEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019
@liggitt
Copy link
Member

liggitt commented Jan 31, 2019

per approved exception

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Jan 31, 2019
@liggitt liggitt added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Jan 31, 2019
@claurence claurence added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 7, 2019
@liggitt
Copy link
Member

liggitt commented Feb 11, 2019

I can do any API review required for this (there may not actually be any visible API changes as part of the beta->stable promotion)

@liggitt
Copy link
Member

liggitt commented Feb 15, 2019

Already merged, no visible API changes: kubernetes/kubernetes#72785

@liggitt liggitt removed their assignment Feb 15, 2019
@liggitt liggitt removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 15, 2019
@npentrel
Copy link

Hey @derekwaynecarr 👋! I'm Naomi, a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@claurence
Copy link

@derekwaynecarr looking over the KEP for this enhancement I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

@npentrel
Copy link

npentrel commented Mar 2, 2019

Hey @derekwaynecarr, gentle ping on the docs PR.

@derekwaynecarr
Copy link
Member Author

@npentrel the docs pr is here: kubernetes/website#13004

@kacole2
Copy link

kacole2 commented Apr 11, 2019

this was included as a stable feature in 1.14. Going to close this issue now.

/milestone clear
/close

@k8s-ci-robot k8s-ci-robot removed this from the v1.14 milestone Apr 11, 2019
@k8s-ci-robot
Copy link
Contributor

@kacole2: Closing this issue.

In response to this:

this was included as a stable feature in 1.14. Going to close this issue now.

/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kacole2 kacole2 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

7 participants