-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contextual logging #3077
Comments
/sig instrumentation |
Hello @pohly v1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting Here’s where this enhancement currently stands:
The status of this enhancement is marked as |
@encodeflush : the KEP PR was merged, all criteria for alpha in 1.24 should be met now. |
Hi @pohly 👋 1.24 Docs shadow here. This enhancement is marked as 'Needs Docs' for the 1.24 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT. Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thanks! |
Hi @pohly 👋 1.24 Release Comms team here. We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet. The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline. For reference, here is the blog for 1.23. Please feel free to reach out any time to me or on the #release-comms channel with questions or comments. Thanks! |
Hello @pohly I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022 Please ensure the following items are completed:
For note, the status of this enhancement is currently marked as Thank you! |
/assign |
I have added two doc PRs to the description. |
/milestone clear |
@pohly can we close this? |
/assign @serathius |
Hey @pohly - with all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀! Thanks for your hard work |
Hello 👋, 1.30 Enhancements team here. Unfortunately, this enhancement did not meet requirements for enhancements freeze. I made an error, this question under If you still wish to progress this enhancement in 1.30, please file an exception request. Thanks! |
@tjons: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone clear |
Hello @pohly 👋, 1.30 Docs Lead here. Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. |
Hi @pohly, @shivanshu1333, and @serathius, 👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating. To opt in, you need to open a Feature Blog placeholder PR against the website repository. |
Doc PR for 1.30 created and linked to in the description |
Hey again @pohly 👋 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 . Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:
Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. |
Hi @pohly - checking in again here. There are about ~6 hours remaining until code freeze. Do you think you'll be able to merge kubernetes/kubernetes#120696 in time? |
Hello @pohly 👋 , Enhancements team here. With all the implementation(code related) PRs merged as per the issue description: This enhancement is now marked as |
Hi @pohly 👋, 1.31 Enhancements Lead here. If you wish to progress this enhancement in v1.31, please opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze. /remove-label lead-opted-in |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Enhancement Description
One-line enhancement description (can be used as a release note): Contextual logging enables the caller of a function to control all aspects of logging (output formatting, verbosity, additional values and names).
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging
Discussion Link: WG Structured Logging
Primary contact (assignee): @pohly
Responsible SIGs: SIG Instrumentation, WG Structured Logging
Enhancement target (which target equals to which milestone):
Alpha
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):Beta
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s): contextual logging: beta in Kubernetes 1.30 website#45288Current configuration
https://github.com/kubernetes/kubernetes/blob/master/hack/logcheck.conf
Status
The following table counts log calls that need to be converted. The numbers for contextual logging include those for structured logging.
At this point, controllers could get converted to contextual logging or one of the components that was already converted to structured logging. If you want to pick one, ping @pohly on the #wg-structured-logging Slack channel. See structured and contextual logging migration instructions for guidance.
Besides migrating log calls, we also might have to migrate from APIs which don't support contextual logging to APIs which do:
From 2022-10-27 ~= Kubernetes 1.26
The focus was on converting kube-controller-manager. Of 1944 unstructured and/or non-contexual logging calls in
pkg/controller
andcmd/kube-controller-manager
, 82% were converted to structured, contextual logging in Kubernetes 1.27.From 2023-03-17 = Kubernetes v1.27.0-beta.0
All of kube-controller-manager got converted.
Tables created with:
@obaranov1, kubernetes/kubernetes#116021, @mengjiao-liu, kubernetes/kubernetes#119147@pravarag, kubernetes/kubernetes#114689, @pohly, kubernetes/kubernetes#119250From 2023-09-18 =~ Kubernetes v1.28
Table created manually and with:
From 2023-11-20 =~ Kubernetes v1.29
Table created with:
The text was updated successfully, but these errors were encountered: