Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashing collision avoidance mechanism for Deployments #287

Closed
0xmichalis opened this issue Apr 29, 2017 · 9 comments
Closed

Hashing collision avoidance mechanism for Deployments #287

0xmichalis opened this issue Apr 29, 2017 · 9 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@0xmichalis
Copy link

0xmichalis commented Apr 29, 2017

Feature Name

  • One-line feature description (can be used as a release note): Hashing collision avoidance mechanism for Deployments
  • Primary contact (assignee): @Kargakis
  • Responsible SIGs: @kubernetes/sig-apps-misc
  • Design proposal link (community repo): Refine the Deployment proposal and switch hashing algorithm community#477
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @janetkuo, @lukaszo
  • Approver (likely from SIG/area to which feature belongs): @smarterclayton
  • Feature target (which target equals to which milestone): 1.7
    • Alpha release target 1.7
@0xmichalis 0xmichalis self-assigned this Apr 29, 2017
@idvoretskyi idvoretskyi added sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels May 3, 2017
@idvoretskyi idvoretskyi added this to the v1.7 milestone May 3, 2017
@0xmichalis 0xmichalis added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels May 21, 2017
@idvoretskyi
Copy link
Member

idvoretskyi commented Jun 16, 2017

@Kargakis please, provide us with the docs PR link (and update the features tracking spreadsheet with it).
/cc @kubernetes/sig-apps-feature-requests

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 16, 2017
@idvoretskyi idvoretskyi removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 16, 2017
@0xmichalis
Copy link
Author

@idvoretskyi this is not a user-facing issue so there are no docs. kubernetes/website#3876 is the closest I can think of since I am mentioning the mechanism added by this feature. The Deployment proposal has more info: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/deployment.md#hashing-collisions

@idvoretskyi
Copy link
Member

idvoretskyi commented Jun 16, 2017 via email

@janetkuo
Copy link
Member

Why is it alpha? Deployment is a beta resource.

@0xmichalis
Copy link
Author

@janetkuo as I understand it, the stage is about the new feature and not the whole resource. A beta resource can have an alpha feature.

@janetkuo
Copy link
Member

Alpha features should be disabled by default: https://github.com/kubernetes/community/blob/master/contributors/devel/api_changes.md#alpha-beta-and-stable-versions

However, this is on by default, and there's no way to turn it off.

IMO this hash collision avoidance mechanism was intended to fix the issues caused by hash collisions; therefore, it's a bug fix rather than a feature -- users cannot opt-out, and they don't see the difference except that the bug is gone in 1.7 (.status.collisionCount is opaque to them).

@luxas
Copy link
Member

luxas commented Jun 20, 2017

@janetkuo Agree that this is more of a bugfix to the Deployments feature in beta...

@0xmichalis
Copy link
Author

Fine by me, changing stage to beta.

@0xmichalis 0xmichalis added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jun 20, 2017
@kow3ns
Copy link
Member

kow3ns commented Jul 19, 2017

@janetkuo @Kargakis /close

justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018
Proposal for porcelain commands to make working with the last-applied…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
None yet
Development

No branches or pull requests

6 participants