Hashing collision avoidance mechanism for Deployments

[0xmichalis]

Feature Name

• One-line feature description (can be used as a release note): Hashing collision avoidance mechanism for Deployments
• Primary contact (assignee): @Kargakis
• Responsible SIGs: @kubernetes/sig-apps-misc
• Design proposal link (community repo): Refine the Deployment proposal and switch hashing algorithm community#477
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @janetkuo, @lukaszo
• Approver (likely from SIG/area to which feature belongs): @smarterclayton
• Feature target (which target equals to which milestone): 1.7
  • Alpha release target 1.7

[idvoretskyi]

@Kargakis please, provide us with the docs PR link (and update the features tracking spreadsheet with it).
/cc @kubernetes/sig-apps-feature-requests

[0xmichalis]

@idvoretskyi this is not a user-facing issue so there are no docs. kubernetes/website#3876 is the closest I can think of since I am mentioning the mechanism added by this feature. The Deployment proposal has more info: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/deployment.md#hashing-collisions

[idvoretskyi]

@Kargakis, thanks.

…

On Fri, Jun 16, 2017, 9:00 PM Michail Kargakis ***@***.***> wrote: @idvoretskyi <https://github.com/idvoretskyi> this is not a user-facing issue so there are no docs. kubernetes/website#3876 <kubernetes/website#3876> is the closest I can think of since I am mentioning the mechanism added by this feature. The Deployment proposal has more info: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/deployment.md#hashing-collisions — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#287 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHOu6b5tSWvqnDTo6qchcijy3hUt4wzks5sEsLSgaJpZM4NMN2C> .

[janetkuo]

Why is it alpha? Deployment is a beta resource.

[0xmichalis]

@janetkuo as I understand it, the stage is about the new feature and not the whole resource. A beta resource can have an alpha feature.

[janetkuo]

Alpha features should be disabled by default: https://github.com/kubernetes/community/blob/master/contributors/devel/api_changes.md#alpha-beta-and-stable-versions

However, this is on by default, and there's no way to turn it off.

IMO this hash collision avoidance mechanism was intended to fix the issues caused by hash collisions; therefore, it's a bug fix rather than a feature -- users cannot opt-out, and they don't see the difference except that the bug is gone in 1.7 (.status.collisionCount is opaque to them).

[luxas]

@janetkuo Agree that this is more of a bugfix to the Deployments feature in beta...

[0xmichalis]

Fine by me, changing stage to beta.

[kow3ns]

@janetkuo @Kargakis /close