Remove klog specific command line arguments from Kubernetes components

[serathius]

Enhancement Description

• One-line enhancement description (can be used as a release note): Deprecate klog specific flags in Kubernetes components

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components/README.md

• Discussion Link: https://groups.google.com/g/kubernetes-dev/c/dAzHAdxe6ok

• Primary contact (assignee): serathius

• Responsible SIGs: sig-instrumentation, sig-arch

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.24
  • Stable release target (x.y): 1.26

• Alpha

  • KEP (k/enhancements) update PR(s): KEP-2845: Initial draft  #2846 Move KEP-2845 to implementable #2912
  • Code (k/k) update PR(s):
    • Klog can be configured without registering flags @pohly
      • component-base/logs: refactor registry kubernetes#105539
      • initialize logging after flag parsing + refactor commands kubernetes#105076
    • Kubernetes logging configuration drops global state @pohly
      • Move not-deprecated klog flags to Logs flag group kubernetes#99265
    • Go-runner is feature complementary to klog flags planned for deprecation @serathius
    • Projects in Kubernetes Org are migrated to go-runner @serathius
      • Remove usage of deprecated klog flags from Kubernetes Org repos kubernetes#106050 (all important projects were migrated)
    • JSON logs format splits stdout and stderr logs
      • JSON output streams kubernetes#104873
  • Docs (k/website) update PR(s): logging: structured logging, klog deprecation website#30505

• Beta

  • KEP (k/enhancements) update PR(s):
    • Go-runner project is well maintained and documented
  • Code (k/k) update PR(s):
    • deprecate klog flags kubernetes#105042
  • Docs (k/website) update(s):
    • Documentation on migrating off klog flags is publicly available

• Stable

  • KEP (k/enhancements) update PR(s): update status of klog flag deprecation #3650
  • Code (k/k) update PR(s): logs: remove deprecated klog flags kubernetes#112120
  • Docs (k/website) update(s):
    • Documentation on migrating off klog flags is publicly available

[serathius]

/sig arch
/sig instrumentation
/wg structured-logging

[k8s-ci-robot]

@serathius: The label(s) sig/arch cannot be applied, because the repository doesn't have them.

In response to this:

/sig arch
/sig instrumentation
/wg structured-logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[serathius]

/sig architecture
/milestone v1.23

[kevindelgado]

Hi @serathius! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo (PR Open).
• KEP status is marked as implementable
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements (PR Open).

Looks like for this one we would just need the KEP (#2912) merge by enhancements freeze :)

All good now!

Thanks!

[kevindelgado]

/stage alpha

[kevindelgado]

/tracked yes

[kevindelgado]

Hi @serathius

Ping! As a reminder your PR (#2912 ) needs to merge by EOD PST tomorrow September 9th to be included in the 1.23 Release. After that time you will need to request an exception.

Lmk if you need anything,
Kevin

[mehabhalodiya]

Hi @serathius 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[serathius]

@pohly I have split Alpha work by milestones. I have assigned to you

• Klog can be configured without registering flags
• Kubernetes logging configuration drops global state

Please confirm and let me know when you will have PR for them.

[serathius]

Marked "Klog can be configured without registering flags" as resolved as technically kubernetes/kubernetes#105076 moved klog flag registration into component-base allowing us to register only flags we want.

[pohly]

@pohly I have split Alpha work by milestones. I have assigned to you

* Klog can be configured without registering flags

* Kubernetes logging configuration drops global state

Please confirm

That's okay. As discussed in https://kubernetes.slack.com/archives/C020CCMUEAX/p1635445845031900, both will be solved by adding fields for -v and -vmodule to LoggingConfiguration. Those two fields then can be set without having to use command line flags (first line item) and the configuration can be passed around before being applied (second line item).

[pohly]

/assign

[hosseinsalahi]

Hello @serathius @pohly

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
• Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as tracked.

Could you please confirm if following PR is part of the implementation for this enhancement?
- #1602

Thank you!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[pohly]

/remove-lifecycle stale

The goal is to complete the deprecation in 1.26.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[dgrisonnet]

/remove-lifecycle stale

[dgrisonnet]

@pohly should this be graduated to stable now that the flags have been removed in k/k?

[pohly]

Yes, I think we could do that.

[logicalhan]

Yes, I think we could do that.

#3650

[sftim]

Could we change the issue title to "Remove klog specific command line arguments from Kubernetes components"?
(currently: "Deprecate klog specific flags in Kubernetes components", but we in fact plan to remove them as well)

[pohly]

/title Remove klog specific command line arguments from Kubernetes components

[logicalhan]

/assign @dgrisonnet to find klog PRs

[k8s-ci-robot]

@logicalhan: GitHub didn't allow me to assign the following users: PRs, to, find, klog.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @dgrisonnet to find klog PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dgrisonnet]

Closing since the KEP is now stable and implemented.