Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job tracking without lingering Pods #2307

Closed
12 tasks done
alculquicondor opened this issue Jan 21, 2021 · 47 comments
Closed
12 tasks done

Job tracking without lingering Pods #2307

alculquicondor opened this issue Jan 21, 2021 · 47 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@alculquicondor
Copy link
Member

alculquicondor commented Jan 21, 2021

Enhancement Description

/sig apps

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 21, 2021
@alculquicondor
Copy link
Member Author

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2021
@alculquicondor
Copy link
Member Author

/assign

@alculquicondor
Copy link
Member Author

It looks like #2232 is almost there. Once it merges, we would have very little time to handle conflicts and go through reviews. So we would likely be deferring this enhancement to 1.22.

cc @ahg-g @soltysh

@ahg-g
Copy link
Member

ahg-g commented May 5, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 5, 2021
@ahg-g
Copy link
Member

ahg-g commented May 5, 2021

@alculquicondor can you update the links to the merged KEP and the open implementation PRs please

@JamesLaverack JamesLaverack added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 5, 2021
@gracenng
Copy link
Member

gracenng commented May 9, 2021

Hi @alculquicondor 👋 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In KEP.yaml, latest-milestone has not been updated
  • In KEP.yaml, milestone (alpha: v1.21, beta: v1.22) doesn't match your current stage

Thanks!

@alculquicondor
Copy link
Member Author

@gracenng
Copy link
Member

My apologies @alculquicondor, I did miss that PR. I've updated Enhancement track sheet and this issue is no longer at risk.

@gracenng
Copy link
Member

gracenng commented May 11, 2021

Hi @alculquicondor 👋 1.22 Enhancements shadow here.
I just wanted to check to see if SIG-Apps will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

@soltysh
Copy link
Contributor

soltysh commented May 11, 2021

Yup, sig-apps is aware and tracking this development.

@chrisnegus
Copy link

Hi @alculquicondor ! I'm @chrisnegus , a Docs Shadow for release 1.22.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@gracenng
Copy link
Member

Hi @alculquicondor 🌞 1.22 enhancements shadow here.

In light of Code Freeze on July 8th, this enhancement current status is at risk as k/k#98238 has not been merged.

Please let me know if there is other code PR associated with this enhancement and feel free to ping me once its merged.

Thanks

@alculquicondor
Copy link
Member Author

Thanks Grace. The PR is approved by the SIG, but still awaiting for api-review. There are no more PRs.

@gracenng
Copy link
Member

gracenng commented Jul 7, 2021

Hi @alculquicondor 🌷 1.22 enhancements shadow here.

A friendly reminder that Code Freeze is tomorrow, on July 8th. Please also be mindful of the docs PR deadline on July 9th

Thanks

@marosset
Copy link
Contributor

marosset commented Nov 7, 2022

Hi @alculquicondor 👋,

It looks like all of the code PRs for this enhancement have been merged so this enhancement is once again tracked for the v1.26 release.

Thanks!

@marosset
Copy link
Contributor

Hi @alculquicondor - since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/2307-job-tracking-without-lingering-pods/kep.yaml setting the status to implemented and then close this issue.
Thanks!

@marosset marosset removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Dec 12, 2022
@alculquicondor
Copy link
Member Author

alculquicondor commented Dec 13, 2022

We still have a few deprecations and removals to do in the next versions, as mentioned in the KEP. Is that fine?

cross reference: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/2307-job-tracking-without-lingering-pods#deprecation

@marosset
Copy link
Contributor

My mistake! Please keep this issue open until the deprecations / removals are complete.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Dec 14, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2023
@alculquicondor
Copy link
Member Author

/remove-lifecycle stale

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Sep 29, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 19, 2024
@alculquicondor
Copy link
Member Author

/remove-lifecycle stale

All the post GA requirements are completed.

/close

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Closing this issue.

In response to this:

/remove-lifecycle stale

All the post GA requirements are completed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Graduating
Archived in project
Development

No branches or pull requests