Auto remove PVCs created by StatefulSet

[kk-src]

Enhancement Description

• One-line enhancement description (can be used as a release note):
  Auto remove PVCs created by StatefulSet

• Kubernetes Enhancement Proposal: KEP-1847: Auto remove PVCs created by StatefulSet.

• Primary contact (assignee): @mattcary

• Responsible SIGs: @sig-apps (with collaboration by @sig-storage)

• Enhancement target (which target equals to which milestone):

  • Alpha release target 1.23
  • Beta release target 1.27
  • Stable release target 1.32

• Beta
  • KEP (k/enhancements) update PR(s): 1847: 1.27 beta update #3800
  • Code (k/k) update PR(s):
    • Graduate StatefulSetAutoDelete to beta kubernetes#116501
  • Docs (k/website) update(s):
    • Update StatefulSet set docs for autodelete graduation to beta website#39926
    • Feature blog for StatefulSet Autodelete beta graduation website#39819
• Stable
  • KEP (k/enhancements) update PR(s): KEP-1847: Promote statefulset autodelete feature to stable #4901
  • Code (k/k) update PR(s): Promote StatefulSetAutoDeletePVC to stable in 1.32 kubernetes#128247
  • Docs (k/website) update(s): KEP-1847 v1.32 stable docs changesAutodelete 132 website#48484

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

Resolves kubernetes/kubernetes#55045

[k8s-ci-robot]

@kk-src: The label(s) sig/sig-storage cannot be applied, because the repository doesn't have them

In response to this:

/sig sig-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kk-src]

/sig storage

[kk-src]

/assign

[pacoxu]

@kubernetes/sig-storage-feature-requests

[k8s-ci-robot]

@pacoxu: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-feature-requests

In response to this:

@kubernetes/sig-storage-feature-requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xing-yang]

CC @dsu-igeek

[kk-src]

Having discussions with @dsu-igeek @msau42 @mattcary
Should have a KEP with the proposal in shortly.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[kikisdeliveryservice]

Hi @kk-src

Enhancements Lead here. Will there be any work for this in 1.20?

Also, as a reminder to be included in a release:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria.

Thanks
Kirsten

[kikisdeliveryservice]

As per #1915 (comment)

marking this is as tracked.

Please note that Enhancements Freeze is October 6th, by which time to be included in the milestone:
The KEP must be merged in an implementable state (not yet merged & provisional)
The KEP must have test plans (missing)
The KEP must have graduation criteria (missing)

Best,
Kirsten

[kikisdeliveryservice]

/milestone v1.20

[mikejoh]

Hi @kk-src 👋!

I'm one of the Enhancement shadows for the 1.20 release cycle. This is a friendly reminder that the Enhancement freeze is roughly one week from now on the 6th of October. I'm repeating the requirements needed by then:

• The KEP must be merged in an implementable state.
  • It's provisional at the moment.
• The KEP must have test plans.
  • Missing in the KEP.
• The KEP must have graduation criteria.
  • Also missing in the KEP.

Let us know if you have any questions etc.!

Thanks!

[mikejoh]

As a reminder, the Enhancements Freeze is Tomorrow October 6th EOD PST. All KEPs and updates must be merged by that time. After October 6th, you will need to request an Exception to be included in the 1.20 Release.

[kikisdeliveryservice]

Hi @kk-src

Enhancements Freeze is now in effect. Unfortunately, your KEP PR has not merged. If you wish to be included in the 1.20 Release, please submit an Exception Request as soon as possible.

Best,
Kirsten
1.20 Enhancements Lead

[kk-src]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[atiratree]

I think it would be better not to promote this feature in 1.32 due to the recent issues: kubernetes/kubernetes#126919 and kubernetes/kubernetes#122400. Mainly because the code changes in kubernetes/kubernetes#122499 were quite substantial and it would be better to wait to gain confidence in the StatefulSetAutoDelete feature.

[mattcary]

That's reasonable. Catching more dependencies like the owner refs admissions plugin could take time.

The changes #122499 have been backported to 1.29 to increase the soak.

It's still some time until 1.32 (the release schedule link isn't even up yet), we can continue to monitor and decide what to do.

[soltysh]

@mattcary I believe concerns raised by Filip are still in place, so why not holding this until 1.33?

[mattcary]

Heh, I totally misread that comment as not promoting in 1.31.

Anyway, it doesn't matter to me. The feature's been in development for 4 years, it's been beta for a year. Nothing has changed in the API since it went beta. The risk of GAing it seems low -- maybe there is some bug like the owner policy change, but it's not likely to change the API. The risk of not GAing is similarly low, it's a minor feature few people care about.

I think the reality is that it's not going to get any usage if it's not GA. When it is GA it will get a little more. At this point I think it's more philosphical; do we want to avoid perma-beta or are we ok with multi-year development cycles?

[soltysh]

Fair point, I also once more looked at the e2es added in kubernetes/kubernetes#122499, those are running without problems for four months now, so I'm inclined to let this in. Although given we're quite late in the cycle it might be hard to go through the enhancement process, so keep that in mind.

/label lead-opted-in
/milestone v1.32
/stage stable

[dipesh-rawat]

Hello @mattcary 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

• Update kep.yaml to mention latest-milestone: v1.32
• Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[dipesh-rawat]

Hello @mattcary 👋, v1.32 Enhancements team here,

Now that PR #4901 has been merged, all the KEP requirements are in place and merged into k/enhancements.

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[michellengnx]

Hello @kk-src and @mattcary 👋, 1.32 Docs Shadow here.
Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[mattcary]

Thanks for the ping, we probably have to update some beta -> GA verbiage. I'll open a placeholder.

[dipesh-rawat]

Hey again @mattcary 👋 v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• Promote StatefulSetAutoDeletePVC to stable in 1.32 kubernetes#128247

@mattcary Please let me know the PRs in k/k that are not listed in the description or not linked with this GitHub issue that we need to track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

[michellengnx]

Hello @kk-src and @mattcary 👋, 1.32 Docs Shadow here. Does this enhancement work planned for 1.32 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Hello @kk-src and @mattcary 👋,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is 4 days away at Thursday October 24, 2024 18:00 PDT.

Thanks,
Michelle

[mattcary]

Open draft placeholder PR kubernetes/website#48484

[wrkode]

👋 Hi there, William here from v1.32 Comms
We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[dipesh-rawat]

Hey again @mattcary 👋, v1.32 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in few days, at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment #1847 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

[dipesh-rawat]

Hello @mattcary 👋, v1.32 Enhancements team here

With all the implementation(code related) PRs merged as per the issue description:

• Promote StatefulSetAutoDeletePVC to stable in 1.32 kubernetes#128247

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!