Priority and Fairness for API Server Requests

[yue9944882]

Enhancement Description

• One-line enhancement description (can be used as a release note): Priority and Fairness for API Server Requests

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1040-priority-and-fairness

• Primary contact (assignee): @yue9944882 @MikeSpreitzer

• Responsible SIGs: sig-api-machinery

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y) 1.18
  • Beta release target (x.y) 1.20
  • Stable release target (x.y) 1.28

• Stable:

  • KEP: KEP-1040: Add borrowing by exempt to APF GA criteria #3991
  • Code:
  • Docs:

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

[kacole2]

@yue9944882 the 1.15 enhancement freeze was on 4/30. The KEP is still in a provisional state and still requires graduation criteria. This will not make it in 1.15 without filing an exception and fixing what I had just mentioned.

[kacole2]

/milestone v1.15
/sig api-machinery
/stage alpha

[makoscafee]

Hey, @yue9944882 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[kacole2]

Hi @yue9944882 @MikeSpreitzer . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[kacole2]

Hi @yue9944882 @MikeSpreitzer , today is code freeze for the 1.15 release cycle. I do not see a reply for any k/k PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[kacole2]

/milestone clear

[evillgenius75]

Hi @MikeSpreitzer and @yue9944882 , I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating to alpha stage in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

I see you have PR kubernetes/kubernetes#78966 referenced above, please include any other relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[yue9944882]

hey, yes please track the feature in the 1.16 milestone. matter of fact this feature is literally active from 1.15 on, as you see in the pull above there's ~300 discussions over the api model since april this year. there're also other poc repos under development:

• https://github.com/aaron-prindle/fq-inflight-rate-limit
• https://github.com/aaron-prindle/fq-apiserver
• https://github.com/mars1024/shuffle-sharding

we will get into 1.16 this time 👏🏻

[kacole2]

/milestone v1.16

[sethmccombs]

Hey @yue9944882 @MikeSpreitzer,

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

[MikeSpreitzer]

@evillgenius75 : Yes, this feature needs docs. I do not see how to update the tracking spreadsheet myself; is that something I leave to you?

@sethmccombs : please see my plea for help on the sig-docs Slack channel of the Kubernetes workspace

[rayandas]

Hey again @yue9944882 @MikeSpreitzer 👋, 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).

• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs of this KEP under the stable section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[a-mccarthy]

Hi @yue9944882 @MikeSpreitzer, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

[npolshakova]

Hey @yue9944882 @MikeSpreitzer, Enhancements lead here. Are both of these PRs tracking the code changes for this KEP?

• [WIP] promote APIPriorityAndFairness to GA kubernetes#118521
• apiserver: set APF featuregate to stable kubernetes#121638

[tkashem]

@npolshakova yes, all the code PRs have merged, thanks!

• apiserver: set APF featuregate to stable kubernetes#121638
• Promote APF API to v1 kubernetes#121089
• apiserver: set APF featuregate to stable kubernetes#121638

and the conformance test pr is being tracked here: kubernetes/kubernetes#121718

[tkashem]

draft PR for doc update: kubernetes/website#43946

[salehsedghpour]

Hi @yue9944882 @MikeSpreitzer , 👋 1.30 Enhancements lead here
As it has graduated to Stable and the KEP status is still implementable, may you please update the status to implemented and close this issue once the update PR has merged?

[salehsedghpour]

/remove-label lead-opted-in

[salehsedghpour]

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

[MikeSpreitzer]

/label lead-opted-in

[MikeSpreitzer]

@salehsedghpour : I created #4429 to update the kep.yaml. I am not entirely clear on where to put the lead-opted-in label, you see I just tried and nothing happened.

[k8s-ci-robot]

@MikeSpreitzer: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[deads2k]

/milestone v1.30
/label lead-opted-in

[salehsedghpour]

@MikeSpreitzer, Thanks for the update.
I guess I made a mistake here, to clarify things, is there going to be any changes on this KEP (except the implemented status)?
If not, this issue can be closed as it is completed (stable), right?

[salehsedghpour]

@MikeSpreitzer, shall we close this issue/Enhancement as #4429 is merged?

[MikeSpreitzer]

We are still getting and contemplating requests for more changes. I am not sure how this goes. Is a KEP an evergreen document that is maintained as a feature changes? Or does it start rotting once the feature goes GA?

[sreeram-venkitesh]

@MikeSpreitzer I believe k/enhancements issues are usually closed after the feature goes GA. @salehsedghpour Please correct me if I'm wrong.

@salehsedghpour: Also, if we don't have any code changes for this KEP in this release, do you think we should mark this KEP as Tracked for enhancements freeze? If we have any code change then it makes sense since we will come back to this again before the code freeze, but if there are no code changes should we keep the KEP in the tracking board?

[salehsedghpour]

@MikeSpreitzer I'm sorry, it's my bad, as @sreeram-venkitesh said, enhancements are usually closed after graduating to stable. For new features, you may need to create a new KEP.

With all that, I'm closing this issue and mark it as removed from milestone.

[salehsedghpour]

/remove-label lead-opted-in

[MikeSpreitzer]

@salehsedghpour : we do have a few things planned for upcoming releases, because of certain changes that have to be staged over several releases.

• Allow zero nominal concurrency shares, going into 1.30 (Allow zero value for the 'nominalConcurrencyShares' field kubernetes#123001).
• Change in storage version to v1, planned for release 1.30 (APF API: change storage version to v1 in 1.30 kubernetes#121119).
• Remove the feature gate, planned for 1.31 (APF: remove feature gate in 1.31 kubernetes#121639)

[salehsedghpour]

/milestone clear