Skip to content

Commit

Permalink
NewVolumeManagerReconstruction GA
Browse files Browse the repository at this point in the history
  • Loading branch information
jsafrane committed Jan 23, 2024
1 parent f361e4b commit fd55da6
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 10 deletions.
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-storage/3756.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ kep-number: 3756
# approver: "@deads2k" # as part of #1710
beta:
approver: "@deads2k"
stable:
approver: "@deads2k"
33 changes: 26 additions & 7 deletions keps/sig-storage/3756-volume-reconstruction/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,19 +104,19 @@ SIG Architecture for cross-cutting KEPs).

Items marked with (R) are required *prior to targeting to a milestone / release*.

- [ ] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
- [X] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
- [X] (R) KEP approvers have approved the KEP status as `implementable`
- [X] (R) Design details are appropriately documented
- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
- [ ] e2e Tests for all Beta API Operations (endpoints)
- [ ] e2e Tests for all Beta API Operations (endpoints)
- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
- [X] (R) Graduation criteria is in place
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
- [ ] (R) Production readiness review completed
- [X] (R) Production readiness review completed
- [ ] (R) Production readiness review approved
- [X] "Implementation History" section is up-to-date for milestone
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes

[kubernetes.io]: https://kubernetes.io/
Expand Down Expand Up @@ -341,7 +341,7 @@ is that it scans `/var/lib/kubelet/pods/*` and reconstructs **all** found
volumes and adds them to ASW as *uncertain*. Only information that is available
[in the Pod directory on the disk are reconstructed into ASW at this point.
* Since the volume reconstruction can be imperfect and can miss `devicePath`,
]() VolumeManager adds all reconstructed volumes to `volumesNeedDevicePath`
VolumeManager adds all reconstructed volumes to `volumesNeedDevicePath`
array, to finish their reconstruction from `node.status.volumesAttached`
later.
* All volumes that failed reconstruction are added to
Expand Down Expand Up @@ -556,6 +556,9 @@ https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-cri-containerd-e2e-cos-gc
> "https://35.247.99.121/api/v1/namespaces": dial tcp 35.247.99.121:443:
> connect: connection refused
A whole new job was added to ensure static pods can start when kubelet restarts: [ci-kubernetes-e2e-storage-kind-disruptive](https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-storage-kind-disruptive/1749449661690679296).
There is a single failure in the last 14 days (captured on 2024-01-23).

### Graduation Criteria

#### Alpha
Expand Down Expand Up @@ -759,7 +762,7 @@ Longer term, we may want to require automated upgrade/rollback tests, but we
are missing a bunch of machinery and tooling and can't do that now.
-->

Not yet. This will be a manual test.
Yes, see https://github.com/kubernetes/enhancements/issues/3756#issuecomment-1906255361 (and expand `Details`).

###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?

Expand Down Expand Up @@ -975,6 +978,20 @@ This through this both in small and large cases, again with respect to the

No.

###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

<!--
Focus not just on happy cases, but primarily on more pathological cases
(e.g. probes taking a minute instead of milliseconds, failed pods consuming resources, etc.).
If any of the resources can be exhausted, how this is mitigated with the existing limits
(e.g. pods per node) or new limits added by this KEP?
Are there any tests that were run/should be run to understand performance characteristics better
and validate the declared limits?
-->

No.

### Troubleshooting

<!--
Expand Down Expand Up @@ -1035,6 +1052,8 @@ Ensure that:

* 1.27: Splitting out as a separate KEP, targeting Beta in this release.

* 1.30: GA.

<!--
Major milestones in the lifecycle of a KEP should be tracked in this section.
Major milestones might include:
Expand Down
6 changes: 3 additions & 3 deletions keps/sig-storage/3756-volume-reconstruction/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,18 @@ see-also:
replaces:

# The target maturity stage in the current dev cycle for this KEP.
stage: beta
stage: stable

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.27"
latest-milestone: "v1.30"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.26" # as part of /keps/sig-storage/1710-selinux-relabeling
beta: "v1.27"
stable: "v1.29"
stable: "v1.30"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down

0 comments on commit fd55da6

Please sign in to comment.