Skip to content

Commit

Permalink
Clarify host wildcard matching
Browse files Browse the repository at this point in the history
Expand the example to be clear that multiple labels in the hostname will not match a wildcard.
  • Loading branch information
hobti01 authored May 27, 2019
1 parent 93a90a4 commit f871958
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions keps/sig-network/20190125-ingress-api-group.md
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,8 @@ The `IngressRule.Host` comment would be changed to:
> If `Host` is a wildcard, then request matches the rule if the http host header
> is to equal to the suffix (removing the first label) of the wildcard rule.
> E.g. wildcard "*.foo.com" matches "bar.foo.com" because they share an equal
> suffix "foo.com".
> suffix "foo.com" but does NOT match "baz.bar.foo.com" because only the first
> label is removed for a match.
### Healthchecks

Expand Down Expand Up @@ -539,4 +540,4 @@ KEP (roughly sorted by practicality):
[re2-syntax]: https://github.com/google/re2/wiki/Syntax
[s3-backend]: TODO
[survey]: https://github.com/bowei/k8s-ingress-survey-2018
[regex-survey]: https://en.wikipedia.org/wiki/Comparison_of_regular_expression_engines
[regex-survey]: https://en.wikipedia.org/wiki/Comparison_of_regular_expression_engines

0 comments on commit f871958

Please sign in to comment.