Skip to content

Commit

Permalink
Merge pull request #2793 from ravisantoshgudimetla/clarify-minReady-S…
Browse files Browse the repository at this point in the history
…econds

Clarify StatefulSets minReadySeconds
  • Loading branch information
k8s-ci-robot authored Jun 28, 2021
2 parents d2d92a9 + 129f358 commit f1c8258
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion keps/sig-apps/2599-minreadyseconds-for-statefulsets/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,12 @@ minReadySeconds is already available as an optional field for Deployments,
DaemonSets, ReplicasSets and Replication Controllers. Enabling this option
helps in bringing StatefulSets on par with other workload controllers.

Note: The important point to understand is when will a pod be considered
`Ready` which might depend on the container probes configured. For example,
for a pod with single container having a readiness check with `initialDelaySeconds`,
for the pod to considered `Available` it has to be implicitly `Ready` for
`initialDelaySeconds`+`minReadySeconds`.

### Goals

StatefulSet Controller honoring minReadySeconds and mark Pod ready only if Pod
Expand All @@ -173,12 +179,15 @@ is available for given time mentioned in minReadySeconds.

Moving minReadySeconds to Pod Spec is beyond the scope of this KEP
because of following reasons:
- The effort to change pod spec would be large.
- The effort to change pod spec would be large. While this also helps other controllers like
endpoint controller to look at the pod status and propagate, the main goal of this KEP is to introduce
minReadySeconds field to StatefulSet spec to bring consistency.
- Currently our workload controllers are inconsistent and we prioritize consistency of experience.
- StatefulSets are just different enough from daemonsets and deployments that real world use of minReadySeconds
for stateful sets might influence any future design or point in a more appropriate direction.

More information about the discussion can be found [here](https://github.com/kubernetes/kubernetes/issues/65098)
and why we are going ahead with this approach as there was consensus to bring consistency of experience.


## Proposal
Expand Down

0 comments on commit f1c8258

Please sign in to comment.