Skip to content

Commit

Permalink
elaborate prr
Browse files Browse the repository at this point in the history
  • Loading branch information
AxeZhan committed Jun 14, 2023
1 parent 4cd8ae0 commit c54cb31
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion keps/sig-node/3960-pod-lifecycle-sleep-action/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,12 @@ No

The feature can be disabled in Alpha and Beta versions by restarting kube-apiserver with the feature-gate off. In terms of Stable versions, users can choose to opt-out by not setting the sleep field.

In this case, the created pods's sleepAction will not take effect, and the new pod with sleepAction is not allowed to create.

###### What happens if we reenable the feature if it was previously rolled back?

New pods with sleep action in prestop hook can be created.
Created pods will execute the sleep hook before terminating.

###### Are there any tests for feature enablement/disablement?

Expand All @@ -319,7 +322,8 @@ No

###### How can a rollout or rollback fail? Can it impact already running workloads?

The change is opt-in, it doesn't impact already running workloads. But problems with the updated validation logic may cause crashes in the apiserver.
The change is opt-in, it doesn't impact already running workloads.
But problems with the updated validation logic may cause errors occur during update/crash process.

###### What specific metrics should inform a rollback?

Expand Down

0 comments on commit c54cb31

Please sign in to comment.